[feat] 질문 생성(ai 제외) 및 최신 질문 조회 완료 #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkdwns414
reviewed
May 28, 2024
Comment on lines
16
to
23
| // @PostMapping("/rooms/{roomId}/questions") | ||
| // public ResponseEntity<Void> createQuestion( | ||
| // @UserId Long userId, | ||
| // @PathVariable Long roomId | ||
| // ) { | ||
| // URI uri = URI.create("/question/" + questionService.create(userId, roomId).toString()); | ||
| // return ResponseEntity.created(uri).build(); | ||
| // } |
There was a problem hiding this comment.
이쪽 부분이 잘 이해가 안 가는데 어떤식으로 동작하는건가요?
cron으로 돌릴거라면 API가 굳이 필요하지 않을 것 같은데 질문 강제 생성인가요?
There was a problem hiding this comment.
테스트해본다고 스케줄설정 전 했던건데 까먹고 안지웠네용
Comment on lines
+84
to
+86
| } else { | ||
| return period.getYears() > 0 || period.getMonths() > 0; | ||
| } |
There was a problem hiding this comment.
이거 else문은 어떤걸 확인하기 위한건가요?
There was a problem hiding this comment.
한 달 이상 또는 일 년 이상 차이날 경우 getDays를 했을 때 4보다 작게 나오는 경우가 있어서 이에 대한 예외처리 입니다
| import org.mockito.MockitoAnnotations; | ||
|
|
||
|
|
||
| public class QuestionServiceTest { |
There was a problem hiding this comment.
다 좋은데 가독성 좋게 사이 줄바꿈이 있으면 남들이 보고 이해하기에 더 좋을 것 같아요!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
질문 생성을 할 때 12시 마다 모든 방의 사람들에게 질문을 생성하면 트래픽이 엄청날 것 같은데 나중에 모여서 얘기해봐요(ai까지 쓰면 엄청날듯)