[fix] 프로젝트 세팅 일부 수정 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢
CI workflow를 짜기는 했지만 저게 정석적인 형태인지까지는 확신하지 못하겠습니다.
빌드 시에 테스트 통과 검사까지 하려면 application.yml에 올바른 데이터베이스 정보가 저장돼있어야 하는데 이를 위해 github actions에서 제공하는 서비스를 통해 DB를 연결했습니다.
RDS의 경우 AWS에서 RDS에 public ipv4를 달면 요금이 부과되게 변경함을 통해 연결된 EC2 내부에서만 RDS에 접속할 수 있어 사용하지 못했습니다.