Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Room 생성 API #20

Merged
merged 8 commits into from
May 20, 2024
Merged

[feat] Room 생성 API #20

merged 8 commits into from
May 20, 2024

Conversation

kmjenny
Copy link
Contributor

@kmjenny kmjenny commented May 19, 2024 •
edited
Loading

Related issue 🛠

Work Description ✏️

  • Room 생성 API
스크린샷 2024-05-20 오전 12 34 45
  • Room Domain 테스트
  • Room 생성 관련 Service 테스트

Uncompleted Tasks 😅

  • Room 생성 시 User 연결 -> Profile 생성
  • UserId 수정

To Reviewers 📢

안한 부분 User를 어떻게 생성해서 확인할지 모르겠어서 일단 주석 처리 해뒀습니다...

@kmjenny kmjenny self-assigned this May 19, 2024
tkdwns414
tkdwns414 requested changes May 19, 2024
View reviewed changes
Copy link
Contributor

@tkdwns414 tkdwns414 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

src/main/java/com/telepigeon/server/controller/RoomController.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/controller/RoomController.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/domain/Room.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/dto/room/request/RoomCreateDto.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/exception/code/NotFoundErrorCode.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/controller/RoomController.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/service/room/RoomService.java Outdated Show resolved Hide resolved
src/main/java/com/telepigeon/server/service/room/RoomService.java Outdated Show resolved Hide resolved
minwoo0419
minwoo0419 reviewed May 19, 2024
View reviewed changes
Copy link
Contributor

@minwoo0419 minwoo0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

상준님이 자세하게 코드를 달아주셔서 저는 더 달지는 않겠습니다! 구현하느라 고생하셨고 코드리뷰 반영되면 다시 오겠습니다 화이팅

src/main/java/com/telepigeon/server/domain/Room.java Show resolved Hide resolved
@kmjenny kmjenny requested a review from minwoo0419 May 19, 2024 17:53
minwoo0419
minwoo0419 approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@minwoo0419 minwoo0419 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!

@kmjenny kmjenny merged commit f064969 into develop May 20, 2024
1 check passed
@kmjenny kmjenny deleted the feat/13 branch May 20, 2024 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@minwoo0419 minwoo0419 minwoo0419 approved these changes

@jihyunniiii jihyunniiii Awaiting requested review from jihyunniiii

@tkdwns414 tkdwns414 Awaiting requested review from tkdwns414

Assignees

@kmjenny kmjenny

Labels
✨ feat ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] Room 방 생성 API
3 participants
@kmjenny @tkdwns414 @minwoo0419