[feat] Answer, Question CRUD 로직 구현 #19
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmjenny
approved these changes
May 19, 2024
tkdwns414
reviewed
May 19, 2024
Comment on lines
16
to
20
| public String create(AnswerCreateDto answerCreateDto, Question question, Profile profile){ | ||
| Answer answer = Answer.create(answerCreateDto, question, profile); | ||
| answerRepository.save(answer); | ||
| return answer.getId().toString(); | ||
| } |
There was a problem hiding this comment.
create 안에 return answerRepository.save(answer)만 남기는건 어떤가요? 저희가 Service를 CRUD로 나누려고 했던 것은 Repository와 Service에서 순환 참조가 일어나지 않도록 핵심 기능을 분리한느것이였기 때문에 안에는 Repository의 기본 메소드만 남아있는 것이 맞을 것 같습니다.
There was a problem hiding this comment.
좋은 지적이네요! 수정하는 게 좋을것같아요 수정하겠습니다
Comment on lines
14
to
18
| public String create(String content, Profile profile){ | ||
| Question question = Question.create(content, profile); | ||
| questionRepository.save(question); | ||
| return question.getId().toString(); | ||
| } |
네 컨트롤러랑 서비스레이어쪽은 추후에 다른 헬퍼들이 만들어졌을때 하는 게 좋을 것 같아서 따로 구현했습니다. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Uncompleted Tasks 😅
To Reviewers 📢