Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nextauth fixes #41

Merged
merged 4 commits into from
Sep 6, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .env
Original file line number Diff line number Diff line change
@@ -1,2 +1,3 @@
NEXT_PUBLIC_BASE_URL=https://cms.tf.fi
NEXT_PUBLIC_GOOGLE_CALENDAR_ID=[email protected]
NEXT_PUBLIC_GOOGLE_CALENDAR_ID=[email protected]
NEXT_TELEMETRY_DISABLED=1
4 changes: 2 additions & 2 deletions components/Page.tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { NextPage } from 'next'
import { PageType } from '@models/page'
import { marked } from 'marked'
import { marked, RendererObject } from 'marked'
import { NavbarLink } from '@lib/api/navbar'
import Header from '@components/header'
import { NationLogo } from '@components/footer/Logos'
Expand All @@ -9,7 +9,7 @@ import TableOfContents from '@components/TableOfContents'
import PageSection from '@components/PageSection'
import Unauthorized from '@components/Unauthorized'

const renderer: marked.RendererObject = {
const renderer: RendererObject = {
image(href: string | null): string {
return `<img class='event-page-image' src=${href} alt='bild' />`
},
Expand Down
28 changes: 12 additions & 16 deletions components/TableOfContents.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -6,22 +6,18 @@ const TableOfContents = ({ sections }: { sections: Section[] }) => {
return (
<>
<h2>Innehållsförteckning</h2>
<table className="table-auto border-separate text-sm">
<tbody>
{sections.map((section, i) => (
<tr key={i}>
{section.attributes.title && (
<Link
className="no-underline hover:underline"
href={`#${titleToAnchor(section.attributes.title)}`}
>
{section.attributes.title}
</Link>
)}
</tr>
))}
</tbody>
</table>
{sections.map(
(section, i) =>
section.attributes.title && (
<Link
key={i}
className="no-underline hover:underline"
href={`#${titleToAnchor(section.attributes.title)}`}
>
{section.attributes.title}
</Link>
)
)}
</>
)
}
Expand Down
4 changes: 2 additions & 2 deletions lib/api/privatepage.ts
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ import { PageType } from '@models/page'
import strapi from '@lib/api/strapi'

export async function fetchPrivatePage(
sessionToken: string,
sessionToken?: string,
slug?: string
): Promise<PageType | null> {
if (slug === undefined) return null
if (slug === undefined || sessionToken === undefined) return null
const query = qs.stringify({
populate: {
sections: {
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
"classnames": "^2.3.1",
"framer-motion": "^10.13.0",
"googleapis": "105",
"marked": "^5.1.0",
"marked": "^8.0.0",
"next": "^13.4.6",
"next-auth": "^4.23.1",
"qs": "^6.11.0",
Expand Down
12 changes: 8 additions & 4 deletions pages/api/auth/[...nextauth].ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,9 @@ const options: NextAuthOptions = {
clientId: process.env.KEYCLOAK_CLIENT_ID || 'strapi',
clientSecret: process.env.KEYCLOAK_CLIENT_SECRET || 'strapi',
issuer: process.env.KEYCLOAK_ISSUER,
httpOptions: {
timeout: 10000,
},
}),
],
session: {
Expand All @@ -17,16 +20,17 @@ const options: NextAuthOptions = {
callbacks: {
async session({ session, token }) {
session.user.token = token.jwt
return { ...session, jwt: token.jwt, id: token.id }
return session
},
async jwt({ token, user, account }) {
if (user) {
const response = await fetch(
`${process.env.NEXT_PUBLIC_BASE_URL}/api/auth/keycloak/callback?access_token=${account?.access_token}`
)
const data = await response.json()
token.jwt = data.jwt
token.id = data.user.id
if (response.ok) {
const data = await response.json()
token.jwt = data.jwt
}
}
return token
},
Expand Down
12 changes: 7 additions & 5 deletions pages/medlem/[privatePage].tsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,18 +19,20 @@ const PrivatePage: NextPage<PrivatePageProps> = ({
session,
...props
}: PrivatePageProps) => (
<Page {...props} isPrivate={true} unauthorized={!session || !props.page} />
<Page {...props} isPrivate={true} unauthorized={session === null} />
)

export const getServerSideProps: GetServerSideProps<{
session: Session | null
}> = async (context) => {
const query = context.query.privatePage
const slug = query instanceof Array ? query[0] : query
const session = await getSession(context)
const page = session?.user?.token
? await fetchPrivatePage(session?.user.token, slug)
: null
let session = await getSession(context)
const page = await fetchPrivatePage(session?.user.token, slug)
// Reset the session if page fetch failed as it's most likely caused by an invalid session token
if (page === null) {
session = null
}
const { logos, navbarLinks } = await getLayoutProps()
return {
props: {
Expand Down
4 changes: 2 additions & 2 deletions pages/nyheter/[slug].tsx
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { GetStaticPaths, GetStaticProps, NextPage } from 'next'
import { PostType } from '@models/post'
import { marked } from 'marked'
import { marked, RendererObject } from 'marked'
import { fetchPost, fetchPosts } from '@lib/api/post'
import { getLayoutProps } from '@utils/helpers'
import { NationLogo } from '@components/footer/Logos'
Expand All @@ -14,7 +14,7 @@ type Props = {
navbarLinks: NavbarLink[]
}

const renderer: marked.RendererObject = {
const renderer: RendererObject = {
image(href: string | null): string {
return `<img class='event-page-image' src=${href} alt='bild' />`
},
Expand Down
8 changes: 4 additions & 4 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -2076,10 +2076,10 @@ lru-cache@^6.0.0:
dependencies:
yallist "^4.0.0"

marked@^5.1.0:
version "5.1.0"
resolved "https://registry.yarnpkg.com/marked/-/marked-5.1.0.tgz#cf51f03ba04dfb3469774029fd0106d258658767"
integrity sha512-z3/nBe7aTI8JDszlYLk7dDVNpngjw0o1ZJtrA9kIfkkHcIF+xH7mO23aISl4WxP83elU+MFROgahqdpd05lMEQ==
marked@^8.0.0:
version "8.0.0"
resolved "https://registry.yarnpkg.com/marked/-/marked-8.0.0.tgz#e808c02daf9d72485477d3ff9a4e193fec94a4db"
integrity sha512-RI/D5csFVreNrFchdKFSdV38GDHJdD7OdmbNWYzGvApPb0A9pyypgfHC/FBH4ugmRE8cr7yg/TH7tu8585eMhA==

merge-stream@^2.0.0:
version "2.0.0"
Expand Down
Loading