Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navbar improvements #36

Merged
merged 8 commits into from
Sep 4, 2023
Merged

Navbar improvements #36

merged 8 commits into from
Sep 4, 2023

Conversation

backjonas
Copy link
Member

  • Limit navbar query to only return required fields
  • Prevent prefetch on navbar link hover
  • Remove alphabetic sorting for page sections
    • Sections can instead be sorted manually in strapi
  • Fix current page not showing correctly in navbar with active anchor link
  • Remove framer-motion from navbar
    • Was causing crashes when refreshing private pages in prod
  • Update collapsed navbar
    • Navbar is now always visible
    • Made hamburger menu smaller and fixed some animations
  • Change content page styling slightly

Copy link
Collaborator

@marnym marnym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just use the classNames library in a few places, since we already have it installed.

components/header/navbar/MenuIcon.tsx Outdated Show resolved Hide resolved
components/header/navbar/MenuIcon.tsx Outdated Show resolved Hide resolved
components/header/navbar/MenuIcon.tsx Outdated Show resolved Hide resolved
components/header/navbar/SideMenu.tsx Outdated Show resolved Hide resolved
@backjonas backjonas merged commit 9da260f into master Sep 4, 2023
1 check passed
@backjonas backjonas deleted the navbar_improvements branch September 4, 2023 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants