Mobile revamp #49
Open
Mobile revamp #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I assume that this PR regards the following issue? #47 |
tlangens
reviewed
Oct 3, 2019
fars/booking/templates/login.html
Outdated
| font-size: 5em; | ||
| } | ||
| h2, h3 { | ||
| text-decoration: underline; |
tlangens
reviewed
Oct 3, 2019
c00k133
reviewed
Oct 6, 2019
| <hr> | ||
| <h2 class="d-flex justify-content-center col-12 py-3">WHAT IS FARS?</h3> | ||
| <p class="offset-1 col-10 offset-md-3 col-md-6">Reservation system with modifiable bookables and timeslots.</p> | ||
| <!-- TODO: Write better description --> |
There was a problem hiding this comment.
Will this TODO be handled in this PR?
There was a problem hiding this comment.
No ;P I don't like writing hypetexts
c00k133
reviewed
Oct 6, 2019
fars/booking/templates/month.html
Outdated
| <div class="col-md-10 col-sm-12 offset-md-1"> | ||
| <div id="calendar" data-bookable="{{bookable.id_str}}" data-user="{{user.id}}" data-locale="{{language_code}}"></div> | ||
| <div class="col-12 offset-lg-1 col-lg-10"> | ||
| <div id="calendar" data-bookable="{{bookable.id_str}}" data-bookablestr="{{bookable}}" data-user="{{user.id}}" data-locale="{{language_code}}"></div> |
There was a problem hiding this comment.
NIT: spacing in variables: {{bookable}} -> {{ bookable }}
We should stay consistent in these if just possible
c00k133
reviewed
Oct 6, 2019
c00k133
reviewed
Oct 8, 2019
Moved css into separate file, did some stylechanges and codestyle"
tlangens
approved these changes
Oct 28, 2019
c00k133
approved these changes
Oct 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New login page and small changes to navbar and month-view