Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[test/#37] 로그인 테스트 #43

Open
wants to merge 19 commits into
base: develop
Choose a base branch
from
Open

[test/#37] 로그인 테스트 #43

wants to merge 19 commits into from

Conversation

kjeongh
Copy link
Contributor

@kjeongh kjeongh commented Dec 23, 2022 •
edited
Loading

추가/수정한 기능 설명

  • mockMVC초기화를 @Autowired가 아닌 MockMvcBuilder로 하도록 수정
  • login컨트롤러 테스트 미완성
  • login 관련 service 테스트코드 작성

check list

  • issue number를 브랜치 앞에 추가 하였는가?
  • 모든 단위 테스트를 돌려보고 기존에 작동하던 테스트에 영향이 없는 것을 확인했는가?
  • 추가/수정사항을 설명하였는가?

@kjeongh kjeongh added the 테스트 테스트 코드를 작성한다. label Dec 23, 2022
@kjeongh kjeongh linked an issue Dec 23, 2022 that may be closed by this pull request
[test] 로그인 관련 테스트 코드 작성 #37
Closed
@kjeongh kjeongh changed the title [Test/#37] [Test/#37] 로그인 테스트 Dec 23, 2022
JeongHunHui
JeongHunHui reviewed Dec 25, 2022
View reviewed changes
Copy link
Member

@JeongHunHui JeongHunHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

천천히 수정 해주세요~!

src/main/java/com/techeer/cokkiri/domain/user/controller/UserController.java Outdated Show resolved Hide resolved
src/main/java/com/techeer/cokkiri/global/entity/BaseEntity.java
@@ -14,9 +14,9 @@
@EntityListeners(AuditingEntityListener.class)
@ToString
public class BaseEntity {
@CreatedDate private LocalDateTime createdAt;
@CreationTimestamp private LocalDateTime createdAt;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

혹시 CreationTimestamp, UpdateTimestamp 같은거는 위에 AuditingEntityListener 가 필요할까요? 만약 필요없다면 지우고 설정파일도 필요가 없어질거같네요

src/test/java/com/techeer/cokkiri/domain/user/repository/UserRepositoryTest.java Outdated Show resolved Hide resolved
src/main/java/com/techeer/cokkiri/domain/user/service/LoginService.java Show resolved Hide resolved
src/main/java/com/techeer/cokkiri/domain/user/service/UserService.java Show resolved Hide resolved
src/test/java/com/techeer/cokkiri/domain/user/repository/UserRepositoryTest.java Outdated Show resolved Hide resolved
@JeongHunHui JeongHunHui changed the title [Test/#37] 로그인 테스트 [test/#37] 로그인 테스트 Jan 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeongHunHui JeongHunHui JeongHunHui left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
테스트 테스트 코드를 작성한다.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] 로그인 관련 테스트 코드 작성
2 participants
@kjeongh @JeongHunHui