Remove exception location information in release builds. #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This wraps exception instantiation in a macro to better control the usage of the __FILE__ macro. It is now only used in debug builds to ensure that no filename strings are included in release binaries.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
__FILE__,__LINE__and__FUNCTION__macros are used in every exception instantiation to provide information about where an exception occurred. Especially the usage of the__FILE__macro is problematic as it fills up the compiled binary with a large amount of strings containing absolute paths to source files.This proposed change here wraps exception instantiation in a macro to better control the usage of the
__FILE__macro. It is now only enabled in debug builds to ensure that no filename strings are included in release binaries.