-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature/calendar2] 커스텀뷰 캘린더 #7
Open
SeojinSeojin
wants to merge
8
commits into
develop
Choose a base branch
from
feature/calendar_customview_challenge
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d7a2254
[feature/calendar2] 바뀌어버린 안스를 위한 초기 세팅
SeojinSeojin 0f90dc1
[feature/calendar2] 무한 뷰페이저 + 페이지 별 시간 계산하는 로직 구현
SeojinSeojin a207ee3
[feature/calendar2] 커스텀뷰 캘린더 만들기
SeojinSeojin 0460e15
[feat/calendar2] 월요일부터 시작하는 날에 한 줄 더 생기는 오류 해결
SeojinSeojin b8196fa
[feature/calendar2] 버전 바꾸기
SeojinSeojin 537e18f
[feature/calendar2] 피드백 반영 (1/3)
SeojinSeojin 0a93ca8
[feature/calendar2] 리뷰반영 (2/3)
SeojinSeojin 66a42f1
[feature/calendar2] 코드릐뷰 반영 (3/3)
SeojinSeojin File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,8 +7,24 @@ import android.view.ViewGroup | |
import androidx.fragment.app.Fragment | ||
import com.teamcatchme.catchmesample.databinding.FragmentCustomCalendarBinding | ||
import java.util.* | ||
import kotlin.properties.Delegates | ||
|
||
class CustomCalendarFragment : Fragment() { | ||
|
||
companion object { | ||
private var MILLS_ID: String = "MILLS_ID" | ||
private var millsId: Long = 0L | ||
|
||
fun newInstance(millsId: Long): CustomCalendarFragment { | ||
val fragment = CustomCalendarFragment() | ||
val args = Bundle() | ||
args.putLong(MILLS_ID, millsId) | ||
fragment.arguments = args | ||
|
||
return fragment | ||
} | ||
} | ||
|
||
class CustomCalendarFragment(private val millsId: Long) : Fragment() { | ||
private var _binding: FragmentCustomCalendarBinding? = null | ||
private val binding: FragmentCustomCalendarBinding | ||
get() = requireNotNull(_binding) | ||
|
@@ -19,6 +35,9 @@ class CustomCalendarFragment(private val millsId: Long) : Fragment() { | |
savedInstanceState: Bundle? | ||
): View { | ||
_binding = FragmentCustomCalendarBinding.inflate(inflater, container, false) | ||
arguments?.let { | ||
millsId = it.getLong(MILLS_ID) | ||
} | ||
Comment on lines
+38
to
+40
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍🏻 |
||
initView() | ||
return binding.root | ||
} | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
3줄을 1줄로