๐ ๋ ์ง ์ถ๋ ฅ ํํ ๋ณ๊ฒฝ #78
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shoeone96
added
โ๏ธย Refactoring
shoeone96
requested review from
ASak1104 and
IjjS
and removed request for
a team
๐ Jacoco ํ ์คํธ ๊ฒฐ๊ณผ
|
IjjS
reviewed
Mar 10, 2024
ASak1104
approved these changes
Mar 11, 2024
Comment on lines
+16
to
24
| public static LocalDate parseToDate(String date, ErrorCode errorCode) { | ||
| notMatching(date, DATE_FORMAT, errorCode); | ||
|
|
||
| DateTimeFormatter formatter = DateTimeFormatter.ofPattern(DATE_PATTERN); | ||
|
|
||
| try { | ||
| return LocalDate.parse(date, formatter); | ||
| } catch (DateTimeParseException e) { | ||
| throw new BadRequestException(errorCode); | ||
| } | ||
| } |
There was a problem hiding this comment.
date๋ฅผ ๋ฐ์์ localDate ๋ก ๋ด๋ณด๋ด์ ๊ทธ๋ฐ์ง parseToDate ๋ฉ์๋ ๋ช
์ด ์กฐ๊ธ ์ด์ํ ๊ฒ ๊ฐ์๋ฐ์?
Comment on lines
+12
to
21
| public record InfoResponse( | ||
| Long userId, | ||
| String nickname, | ||
| String profileImg, | ||
| Integer height, | ||
| Integer weight, | ||
| LocalDate birthDate, | ||
| String birthDate, | ||
| Sex sex, | ||
| ExerciseIntensity exerciseIntensity | ||
| ) { |
There was a problem hiding this comment.
์ด๊ฒ๋ swagger ์๊ฐ์ ํด๋ณด๋ฉด ์ด๋ป๊ฒ ๊ตฌ์ฒด์ ์ผ๋ก ์ ์ ์ ์์ ์ง ๊ณ ๋ฏผํด๋ด์ผ๊ฒ ๋ค์
Comment on lines
+26
to
+32
| public static String parseToString(LocalDate date, ErrorCode errorCode) { | ||
| try { | ||
| return date.format(formatter); | ||
| } catch (DateTimeParseException e) { | ||
| throw new BaseException(errorCode); | ||
| } | ||
| } |
There was a problem hiding this comment.
Validator๊ฐ parse๋ฅผ ํ๋๋ก ์ฑ
์์ ๋ถ์ฌํด๋ ๋ ์ง ์๊ฐํด๋ด์ผ ํ ๊ฒ ๊ฐ์์
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๐ซ ๊ด๋ จ ์ด์
๐ ์ฃผ์ ๋ณ๊ฒฝ์ฌํญ
DateValidator์ ๋ฉ์๋๋ฅผ ์ถ๊ฐํ์ฌ ๋ณ๊ฒฝ ๋ฐ format ๊ฒ์ฌ ์งํ
๐ก ๊ธฐํ์ฌํญ