Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

๐Ÿš€ ๋ฉ”์ดํŠธ ๋ชจ์ง‘ ๋ชฉ๋ก ์กฐํšŒ API ๊ตฌํ˜„ #117

Merged
merged 6 commits into from
Mar 18, 2024
Merged

๐Ÿš€ ๋ฉ”์ดํŠธ ๋ชจ์ง‘ ๋ชฉ๋ก ์กฐํšŒ API ๊ตฌํ˜„ #117

merged 6 commits into from
Mar 18, 2024

Conversation

IjjS
Copy link
Contributor

@IjjS IjjS commented Mar 13, 2024

๐ŸŽซ ๊ด€๋ จ ์ด์Šˆ

๐Ÿš€ ์ฃผ์š” ๋ณ€๊ฒฝ์‚ฌํ•ญ

  • ๋ฉ”์ดํŠธ ๋ชจ์ง‘ ๋ชฉ๋ก ์กฐํšŒ API
  • postId๊ฐ€ ๋“ค์–ด๊ฐˆ ์‹œ -> ํ•ด๋‹น ํฌ์ŠคํŠธ์˜ ๋ฉ”์ดํŠธ ๋ชจ์ง‘ ์กฐํšŒ
  • postId๊ฐ€ ์—†์„ ์‹œ
    • depth1, 2, 3์ด ์ „๋ถ€ ์žˆ์„ ๋•Œ -> ์ฃผ์†Œ ๊ธฐ๋ฐ˜ ์กฐํšŒ
    • ํ•˜๋‚˜๋ผ๋„ ์—†์„ ๋•Œ -> ์ „์ฒด ์กฐํšŒ

๐Ÿ’ก ๊ธฐํƒ€์‚ฌํ•ญ

  • ์ง€๋„๋ฅผ ๋„“ํ˜”์„ ๋•Œ ๋” ๋„“์€ ์ฃผ์†Œ๋ฅผ ๋ณด์—ฌ์ฃผ๊ฒŒ ๋œ๋‹ค๋ฉด depth1, 2, 3์ค‘ ํ•˜๋‚˜์”ฉ ํ—ˆ์šฉ์„ ํ•  ์˜ˆ์ •

@IjjS IjjS added ๐Ÿ• ์ง„๋„๊ฐœ ํ•˜๋‚˜! ๋งŽ์ด ๊ธ‰ํ•จ!!!!! (1์ผ ๋‚ด ๋ฆฌ๋ทฐ) โœ…ย Feature ์ƒˆ์นœ๊ตฌ~! labels Mar 13, 2024
@IjjS IjjS self-assigned this Mar 13, 2024
@IjjS IjjS requested a review from a team as a code owner March 13, 2024 18:42
@IjjS IjjS requested review from ASak1104 and shoeone96 and removed request for a team March 13, 2024 18:42
@IjjS IjjS changed the base branch from feature to feature-get-mate March 13, 2024 18:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Mar 13, 2024 •
edited
Loading

๐Ÿ“‘ Jacoco ํ…Œ์ŠคํŠธ ๊ฒฐ๊ณผ

Overall Project 81.53% -0.75% ๐Ÿ
Files changed 80.82% ๐Ÿ

File Coverage
SimpleMateResponse.java 100% ๐Ÿ
MateCursorDto.java 100% ๐Ÿ
HttpRequestsConfigurer.java 100% ๐Ÿ
MateQueryRepositoryImpl.java 92.83% -7.17% ๐Ÿ
MateService.java 89.52% -10.48% ๐Ÿ
MateController.java 0% -48.94% โŒ

ASak1104
ASak1104 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@ASak1104 ASak1104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์Šต๋‹ˆ๋‹ค!

shoeone96
shoeone96 approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@shoeone96 shoeone96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

๊ณ ์ƒํ•˜์…จ์–ด์š”!

src/main/java/team/silvertown/masil/common/scroll/dto/NormalListRequest.java Outdated Show resolved Hide resolved
src/main/java/team/silvertown/masil/mate/repository/mate/MateQueryRepositoryImpl.java Show resolved Hide resolved
src/main/java/team/silvertown/masil/mate/service/MateService.java Show resolved Hide resolved
Base automatically changed from feature-get-mate to feature March 14, 2024 13:09
@IjjS IjjS merged commit 4df040e into feature Mar 18, 2024
1 check passed
@IjjS IjjS deleted the feature-get-mate-list branch March 18, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shoeone96 shoeone96 shoeone96 approved these changes

@ASak1104 ASak1104 ASak1104 approved these changes

Assignees

@IjjS IjjS

Labels
โœ…ย Feature ์ƒˆ์นœ๊ตฌ~! ๐Ÿ• ์ง„๋„๊ฐœ ํ•˜๋‚˜! ๋งŽ์ด ๊ธ‰ํ•จ!!!!! (1์ผ ๋‚ด ๋ฆฌ๋ทฐ)
Projects
MasilGasil BE Project
Status: Done
Milestone
๋ฉ”์ดํŠธ MVP ๊ตฌํ˜„
Development

Successfully merging this pull request may close these issues.

โœ… ๋ฉ”์ดํŠธ ๋ชจ์ง‘ ๋ชฉ๋ก ์กฐํšŒ API ๊ตฌํ˜„
3 participants
@IjjS @ASak1104 @shoeone96