Merge pull request #94 from Team-Ladefuchs/dev/code-quality

enable static code analysis

.github/workflows/build.yml

@@ -51,3 +51,38 @@ jobs:
           path: |
             Ladefuchs/app/build/outputs/apk/debug/app-debug.apk
             Ladefuchs/app/build/outputs/apk/release/app-release-unsigned.apk
+
+  testing:
+      - uses: actions/checkout@v3
+
+      - name: Set up JDK 17
+        uses: actions/setup-java@v1
+        with:
+          java-version: 17
+
+      - name: Write API key into build config
+        env:
+          API_TOKEN: ${{ secrets.API_KEY }}
+        run: echo apiKey=$API_TOKEN > Ladefuchs/secrets.properties
+
+      - name: Build fw
+        working-directory: Ladefuchs
+        run: |
+          ./gradlew koverXmlReport
+
+      - name: Upload test reports
+        if: always()
+        uses: actions/upload-artifact@v3
+        with:
+          name: tests
+          path: Ladefuchs/build/reports
+
+      - name: Add coverage report to PR
+        uses: mi-kas/kover-report@v1
+        with:
+          path: ${{ github.workspace }}/Ladefuchs/build/reports/kover/result.xml
+          token: ${{ secrets.GITHUB_TOKEN }}
+          title: App Coverage
+          update-comment: true
+          min-coverage-overall: 20
+          min-coverage-changed-files: 50

Ladefuchs/app/build.gradle

@@ -2,6 +2,8 @@ plugins {
     id 'com.android.application'
     id 'kotlin-android'
     id 'kotlin-parcelize'
+    id 'io.gitlab.arturbosch.detekt' version '1.22.0'
+    id 'org.jetbrains.kotlinx.kover' version '0.7.6'
 }
 
 android {
@@ -46,8 +48,12 @@ android {
     namespace 'app.ladefuchs.android'
 }
 
+// https://detekt.dev/gradle.html
+detekt {
+    config = files("../detekt.yml")
+}
+
 dependencies {
-    implementation fileTree(dir: "libs", include: ["*.jar"])
     implementation(platform("org.jetbrains.kotlin:kotlin-bom:$kotlin_version"))
     implementation 'androidx.core:core-ktx:1.10.1'
     implementation 'androidx.appcompat:appcompat:1.6.1'

Ladefuchs/detekt.yml

@@ -0,0 +1,14 @@
+# Find all defined configuration options in the default configuration
+# https://github.com/detekt/detekt/blob/main/detekt-core/src/main/resources/default-detekt-config.yml
+
+naming:
+  FunctionNaming:
+    # adjust pattern to support compose function naming
+    functionPattern: '([A-Za-z][a-zA-Z0-9]*)|(`.*`)'
+
+  TopLevelPropertyNaming:
+    constantPattern: '[A-Z][_A-Z0-9]*'
+
+style:
+  MagicNumber:
+    active: false