Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/#247 store detail edit #264

Open
wants to merge 55 commits into
base: develop
Choose a base branch
from
Open

Feature/#247 store detail edit #264

wants to merge 55 commits into from

Conversation

0se0
Copy link
Contributor

@0se0 0se0 commented Nov 6, 2024

📌 Issue

⛳️ Work Description

-2차 스프린트

📸 Screenshot

동영상

  • Video 1:
3.mp4

이미지

Image 1 Image 2
Image 2 Image 3

📢 To Reviewers

  • 메뉴 개수를 제대로 불러오지 못했습니다..

0se0 added 30 commits October 8, 2024 13:00
@0se0
Feature #247: icon
7add8d1
@0se0
Feature #247: SegmentedButton
f874c93
@0se0
Feature #247: HankkiModMenuField
0ce098a
@0se0
Feature #247: MenuItemComponent
8aaba0b
@0se0
Feature #247: edit bottomsheet
a31c238
@0se0
Feature #247: EditMenuRoute
8a75f6f
@0se0
Feature #247: EditMenuBottomSheet
f15aa99
@0se0
Feature #247: NavController.navigateStoreDetail
9ecd6dd
@0se0
Feature #247: EditModRoute
a030f5d
@0se0
Create #247: edit navigation
126d375
@0se0
Feature #247: connect edit modify api
65bf9ed
@0se0
Update #247: focus out
a524d93
@0se0
Update #247: focusing menu textfield
dc37a87
@0se0
Feature #247: nickname, edit success
5c6fb85
@0se0
Feature #247: success img
7d0324c
@0se0
Feature #247: delete menu
f36a1bc
@0se0
#247 temporary storage
4ab0478
@0se0
Merge branch 'develop' into feature/#247-store-detail-edit
2e34b76
@0se0
#247: post menu api
4140b38
@0se0
Feature #247: post menu domain
4caf176
@0se0
Feature #247: Update HankkiModMenuField
03e65d6
@0se0
Feature #247: Create PriceWarningMessage
cb66683
@0se0
Feature #247: Update package
54ee9ed
@0se0
Feature #247: Create EditMenuBottomSheet
5cda705
@0se0
Feature #247: Create AddMenuRoute
1680c9c
@0se0
Feature #247: Create EditModRoute
186c33c
@0se0
Feature #247: Create EditMenuRoute
acd495b
@0se0
Feature #247: Update StoreDetail
9d70df8
@0se0
Feature #247: Update navigator
133189e
@0se0
Feature #247: Create DeleteSuccessRoute
e329309
@0se0 0se0 added this to the 3차 스프린트 개발 milestone Nov 6, 2024
@0se0 0se0 requested review from chattymin and hyeeum November 6, 2024 15:29
@0se0 0se0 self-assigned this Nov 6, 2024
chattymin
chattymin requested changes Nov 6, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

대부분의 뷰에서 같은 실수가 반복되고 있어요.
2/3정도만 읽고 밑에는 안읽어서 코리가 없는거지 수정할게 없는게 아니니까 전부 다 수정해서 다시 리퀘스트 부탁드려요.

...detail/src/main/java/com/hankki/data/storedetail/repositoryImpl/StoreDetailRepositoryImpl.kt Outdated Show resolved Hide resolved
...ure/storedetail/src/main/java/com/hankki/feature/storedetail/navigation/StoreDetailScreen.kt Outdated Show resolved Hide resolved
feature/main/src/main/java/com/hankki/feature/main/MainNavigator.kt Outdated Show resolved Hide resolved
feature/storedetail/src/main/java/com/hankki/feature/storedetail/StoreDetailRoute.kt Show resolved Hide resolved
feature/storedetail/src/main/java/com/hankki/feature/storedetail/StoreDetailRoute.kt Outdated Show resolved Hide resolved
...storedetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/AddMenuRoute.kt Outdated Show resolved Hide resolved
...storedetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/AddMenuRoute.kt Outdated Show resolved Hide resolved
...storedetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/AddMenuRoute.kt Outdated Show resolved Hide resolved
...tail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/AddMenuSuccessRoute.kt Outdated Show resolved Hide resolved
...tail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/add/AddMenuSuccessRoute.kt Outdated Show resolved Hide resolved
hyeeum
hyeeum approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@hyeeum hyeeum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

일단 약간 졸린 상태로 본거라서... 내일 저녁에도 다시 한 번 확인하겠습니다
복학과 시험기간이슈로 너무 힘드셨을텐데 고생하셨어요 ㅜ.ㅜ
나머지는 자잘한건데 8000원관련 이슈 + 뒤로가기 사라짐 이슈 한 번 확인부탁드려요 :)

feature/main/src/main/java/com/hankki/feature/main/MainNavigator.kt Show resolved Hide resolved
feature/storedetail/src/main/java/com/hankki/feature/storedetail/StoreDetailViewModel.kt Outdated Show resolved Hide resolved
...ail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/EditModSucceedRoute.kt Outdated Show resolved Hide resolved
...e/storedetail/src/main/java/com/hankki/feature/storedetail/navigation/navigateStoreDetail.kt Outdated Show resolved Hide resolved
feature/storedetail/src/main/res/drawable/img_add.png Outdated Show resolved Hide resolved
...toredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/EditModRoute.kt Outdated Show resolved Hide resolved
...toredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/EditModRoute.kt Outdated Show resolved Hide resolved
...toredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/EditModRoute.kt Outdated Show resolved Hide resolved
...e/storedetail/src/main/java/com/hankki/feature/storedetail/navigation/navigateStoreDetail.kt Outdated Show resolved Hide resolved
...oredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/EditMenuRoute.kt Outdated
Comment on lines 201 to 207
// if (selectedMenu == null) {
// BottomBlurLayout(
// imageBlur = com.hankki.core.designsystem.R.drawable.img_white_gradient_bottom_middle,
// modifier = Modifier.align(Alignment.BottomCenter)
// )
// }

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

레전드 주석 발생!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기 블러 추가 부분이라 추출하고 넣어 놓을게용

@0se0 0se0 requested a review from chattymin November 8, 2024 00:36
chattymin
chattymin requested changes Nov 8, 2024
View reviewed changes
Copy link
Member

@chattymin chattymin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다!
한번 더 확인부탁드려요

...detail/src/main/java/com/hankki/data/storedetail/repositoryImpl/StoreDetailRepositoryImpl.kt Show resolved Hide resolved
feature/main/src/main/java/com/hankki/feature/main/MainNavigator.kt
Comment on lines +180 to +182
popUpTo(navController.graph.startDestinationId) {
inclusive = true
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기로 이동했을 때 문제 없나요??
이동 후 뒤로가기나 페이지 이동등 해보고 문제없다면 오케입니당

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이번에 추가된 다른 navigate 함수들도 마찬가지!

...ure/storedetail/src/main/java/com/hankki/feature/storedetail/component/HankkiModTextField.kt Show resolved Hide resolved
...ure/storedetail/src/main/java/com/hankki/feature/storedetail/component/HankkiModTextField.kt Show resolved Hide resolved
feature/storedetail/src/main/java/com/hankki/feature/storedetail/component/SegmentedButton.kt Show resolved Hide resolved
...toredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/mod/ModRoute.kt Show resolved Hide resolved
...toredetail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/mod/ModState.kt Show resolved Hide resolved
...ail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/mod/ModSuccessRoute.kt Show resolved Hide resolved
...detail/src/main/java/com/hankki/feature/storedetail/editbottomsheet/edit/mod/ModViewModel.kt Show resolved Hide resolved
...e/storedetail/src/main/java/com/hankki/feature/storedetail/navigation/navigateStoreDetail.kt Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyeeum hyeeum hyeeum approved these changes

@chattymin chattymin chattymin requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@0se0 0se0

Labels
UI 📱 UI 작업 세영 🦌
Projects
None yet
Milestone
3차 스프린트 개발
Development

Successfully merging this pull request may close these issues.

[Feature] store-detail-edit
3 participants
@0se0 @chattymin @hyeeum