feat - 더미 앱 생성 api 구현 #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HMH/HMH-Server into feat/#73-get-dummy-app-api
jumining
approved these changes
Jan 18, 2024
Comment on lines
+6
to
+17
| @Deprecated | ||
| public record DummyAppListResponse( | ||
| List<DummyApp> apps | ||
| ) { | ||
| public static DummyAppListResponse of() { | ||
| List<DummyApp> dummyAppList = new ArrayList<>(); | ||
| dummyAppList.add(new DummyApp("Netflix","https://github.com/Team-HMH/HMH-Server/assets/69035864/dd068b83-641a-4bff-b4f5-381ea6e04d44")); | ||
| dummyAppList.add(new DummyApp("Instagram","https://github.com/Team-HMH/HMH-Server/assets/69035864/bd572377-9dd9-47e7-a9f4-9efbbe66cd2e")); | ||
| dummyAppList.add(new DummyApp("YouTube","https://github.com/Team-HMH/HMH-Server/assets/69035864/8afa60c0-bf1d-4ff0-9b50-4d1558a71f0a")); | ||
| return new DummyAppListResponse(dummyAppList); | ||
| } | ||
| } |
There was a problem hiding this comment.
Q. 앱 3개를 한꺼번에 반환 해주는 건가요?
There was a problem hiding this comment.
그렇게 반환해달라는 클라이언트의 요청이 있었습니다!
금방 삭제할 api이므로 복잡하게 여러 파일로 확장성을 위해 분할하는 것 보다 한 파일에 작성하고 한 번에 삭제할 수 있도록 하였습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue 🚀
Work Description 💚
PR 참고 사항