refactor: security 모듈 CustomException 정의 및 ErrorCode 정리 #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimday0326
approved these changes
Jan 8, 2024
Comment on lines
+32
to
+40
| protected ResponseEntity<ErrorResponse> handleMemberCustomException(CustomException ex) { | ||
| log.warn(">>>>> MemberCustomException : {}", ex); | ||
| BaseErrorCode errorCode = ex.getErrorCode(); | ||
| return ResponseEntity.status(errorCode.getStatus()).body(errorCode.getErrorResponse()); | ||
| } | ||
|
|
||
| @ExceptionHandler(SecurityCustomException.class) | ||
| protected ResponseEntity<ErrorResponse> handleSecurityCustomException(SecurityCustomException ex) { | ||
| log.warn(">>>>> SecurityCustomException : {}", ex); |
Comment on lines
-31
to
+35
| public static void setErrorResponse(HttpServletResponse response, HttpStatus httpStatus) | ||
| public static void setErrorResponse(HttpServletResponse response, HttpStatus httpStatus, Object body) | ||
| throws IOException { | ||
| String responseBody = objectMapper.writeValueAsString( | ||
| new ErrorResponse(httpStatus.name(), httpStatus.getReasonPhrase())); | ||
| response.setContentType(MediaType.APPLICATION_JSON_VALUE); | ||
| response.setStatus(httpStatus.value()); | ||
| response.setCharacterEncoding("UTF-8"); | ||
| response.getWriter().write(responseBody); | ||
| objectMapper.writeValue(response.getOutputStream(), body); |
park0jae
pushed a commit
that referenced
this pull request
Jan 9, 2024
* refactor: ErrorCode 정리 * refactor: HttpResponseUtil 적용 * refactor: SecurityCustomException 생성, 적용 * refactor: GlobalExceptionHandler 리팩터링 --------- Co-authored-by: Kim Dae Hwi <[email protected]>
park0jae
pushed a commit
that referenced
this pull request
Jan 9, 2024
* fix: api 이름 변경 * feat : 실시간 검색 기능 구현 - Aggregation 제외 * feat: #151 실시간 검색 document 추가, 쿼리 작성 * test: 멤버 도메인 test.http 파일 작성 (#149) * test: member 관련 http 테스트 추가 * test: 슈퍼관리자, 관리자 http 테스트 추가 --------- Co-authored-by: 조은비 <[email protected]> * refactor: 공통 BaseErrorCode 정의 (#153) Co-authored-by: 조은비 <[email protected]> * fix: CustomException의 필드를 BaseErrorCode로 변경 (#155) * fix: CustomException의 필드를 BaseErrorCode로 변경 * fix: BaseErrorCode 수정 * feat: 이탈된 예매에 대한 좌석 상태 변경 배치 (#157) * feat: 이탈된 예매에 대한 좌석 상태 변경 배치 * chore --------- Co-authored-by: byulcode <[email protected]> * docs: 예매 http 작성 (#161) * docs: http 유저 시나리오 작성 * fix: createBooking에서 세션 아이디 삭제하는 로직 비동기 메서드로 분리 * docs: http 작성 * refactor: security 모듈 CustomException 정의 및 ErrorCode 정리 (#159) * refactor: ErrorCode 정리 * refactor: HttpResponseUtil 적용 * refactor: SecurityCustomException 생성, 적용 * refactor: GlobalExceptionHandler 리팩터링 --------- Co-authored-by: Kim Dae Hwi <[email protected]> * feat: #151 aggregation 구현, source 포함 조건 추가 --------- Co-authored-by: Kim Dae Hwi <[email protected]> Co-authored-by: 조은비 <[email protected]> Co-authored-by: Hanna Lee <[email protected]> Co-authored-by: byulcode <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
resolve: #156