Skip to content

Commit

Permalink
chore: no longer using commitlint
Browse files Browse the repository at this point in the history
  • Loading branch information
Eveeifyeve committed Apr 7, 2024
1 parent 86e438d commit 3db956f
Show file tree
Hide file tree
Showing 7 changed files with 57 additions and 136 deletions.
28 changes: 0 additions & 28 deletions .github/workflows/PrQuality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,31 +25,3 @@ jobs:

- name: Check stylelint
run: bunx stylelint src/styles/**/*.css

CommitQuality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: oven-sh/setup-bun@v1
with:
bun-version: latest

- name: Install packages
run: |
bun install || echo "::warning::Warning: Failed to install packages"
- name: Print versions
run: |
bun --version || echo "::warning::Warning: Failed to print bun version"
bunx commitlint --version || echo "::warning::Warning: Failed to print commitlint version"
- name: Install commitlint
run: |
bun install conventional-changelog-conventionalcommits || echo ::warning::"Warning: Failed to install conventional-changelog-conventionalcommits"
bun install commitlint@latest || echo "::warning::Warning: Failed to install commitlint"
- name: Validate current commit (last commit) with commitlint
if: github.event_name == 'push'
run: |
bunx commitlint --from HEAD~1 --to HEAD --verbose || echo "::warning::Warning: Commitlint validation failed for the last commit"
26 changes: 1 addition & 25 deletions .github/workflows/Quality.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,28 +23,4 @@ jobs:
- name: Install Deps
run: bun install
- name: Check stylelint
run: bunx stylelint src/styles/**/*.css

CommitQuality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0

- uses: oven-sh/setup-bun@v1
with:
bun-version: latest
- name: Install packages
run: bun install

- name: Print versions
run: |
bun --version
bunx commitlint --version
- name: Validate current commit (last commit) with commitlint
if: github.event_name == 'push'
run: bunx commitlint --from HEAD~1 --to HEAD --verbose
- name: Validate PR commits with commitlint
if: github.event_name == 'pull_request'
run: bunx commitlint --from ${{ github.event.pull_request.head.sha }}~${{ github.event.pull_request.commits }} --to ${{ github.event.pull_request.head.sha }} --verbose
run: bunx stylelint src/styles/**/*.css
18 changes: 0 additions & 18 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,24 +39,6 @@ jobs:
- name: Check stylelint
run: bun stylelint

commitquality:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 0
- uses: oven-sh/setup-bun@v1
with:
bun-version: latest

- name: Install packages
run: |
bun install
- name: Validate current commit (last commit) with commitlint
if: github.event_name == 'push'
run: bunx commitlint --from HEAD~1 --to HEAD --verbose

build:
needs: [commitquality, quality]
runs-on: ubuntu-latest
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,3 @@ package-lock.json
.direnv
.devenv

# Pre-Commit
.pre-commit-config.yaml
4 changes: 0 additions & 4 deletions .husky/commit-msg

This file was deleted.

1 change: 1 addition & 0 deletions .pre-commit-config.yaml
114 changes: 55 additions & 59 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,61 +1,57 @@
{
"name": "teaclient-website",
"type": "module",
"version": "0.0.1",
"scripts": {
"dev": "astro dev",
"preview": "astro preview",
"build": "astro build",
"astro": "astro",
"lint": "biome check --apply . && stylelint 'src/styles/**/*.css' --fix",
"fmt": "biome format . --write",
"biome": "bunx @biomejs/biome",
"check": "biome check . && stylelint 'src/styles/**/*.css'&& bun astro check",
"postinstall": "husky install"
},
"trustedDependencies": ["sharp"],
"stylelint": {
"extends": "stylelint-config-standard",
"plugins": ["stylelint-scss"],
"customSyntax": "postcss-scss",
"rules": {
"at-rule-no-unknown": null,
"selector-class-pattern": null,
"scss/at-rule-no-unknown": true,
"custom-property-pattern": null
}
},
"commitlint": {
"extends": ["@commitlint/config-conventional"]
},
"dependencies": {
"@astrojs/mdx": "^2.0.2",
"@astrojs/rss": "^4.0.5",
"@astrojs/sitemap": "^3.1.1",
"@astrojs/tailwind": "^5.1.0",
"@astrojs/ts-plugin": "^1.3.1",
"astro-meta-tags": "^0.2.1",
"astro-seo": "^0.8.0",
"axios": "^1.6.5",
"sass": "^1.71.1",
"sharp": "^0.33.2",
"tailwind-merge": "^2.2.1",
"tailwindcss": "^3.4.1",
"web-vitals": "^3.5.0"
},
"devDependencies": {
"@astrojs/check": "^0.5.10",
"@biomejs/biome": "^1.5.3",
"@commitlint/cli": "^18.4.3",
"@commitlint/config-conventional": "^18.4.3",
"@types/node": "^20.8.3",
"astro": "^4.2.3",
"husky": "^9.0.11",
"postcss-scss": "^4.0.9",
"stylelint": "^16.3.1",
"stylelint-config-standard": "^36.0.0",
"stylelint-scss": "^6.2.1",
"typescript": "^5.2.2"
},
"packageManager": "[email protected]"
"name": "teaclient-website",
"type": "module",
"version": "0.0.1",
"scripts": {
"dev": "astro dev",
"preview": "astro preview",
"build": "astro build",
"astro": "astro",
"lint": "biome check --apply . && stylelint 'src/styles/**/*.css' --fix",
"fmt": "biome format . --write",
"biome": "bunx @biomejs/biome",
"check": "biome check . && stylelint 'src/styles/**/*.css'&& bun astro check"
},
"trustedDependencies": ["sharp"],
"stylelint": {
"extends": "stylelint-config-standard",
"plugins": ["stylelint-scss"],
"customSyntax": "postcss-scss",
"rules": {
"at-rule-no-unknown": null,
"selector-class-pattern": null,
"scss/at-rule-no-unknown": true,
"custom-property-pattern": null
}
},
"commitlint": {
"extends": ["@commitlint/config-conventional"]
},
"dependencies": {
"@astrojs/mdx": "^2.0.2",
"@astrojs/rss": "^4.0.5",
"@astrojs/sitemap": "^3.1.1",
"@astrojs/tailwind": "^5.1.0",
"@astrojs/ts-plugin": "^1.3.1",
"astro-meta-tags": "^0.2.1",
"astro-seo": "^0.8.0",
"axios": "^1.6.5",
"sass": "^1.71.1",
"sharp": "^0.33.2",
"tailwind-merge": "^2.2.1",
"tailwindcss": "^3.4.1",
"web-vitals": "^3.5.0"
},
"devDependencies": {
"@astrojs/check": "^0.5.10",
"@biomejs/biome": "^1.5.3",
"@types/node": "^20.8.3",
"astro": "^4.2.3",
"postcss-scss": "^4.0.9",
"stylelint": "^16.3.1",
"stylelint-config-standard": "^36.0.0",
"stylelint-scss": "^6.2.1",
"typescript": "^5.2.2"
},
"packageManager": "[email protected]"
}

0 comments on commit 3db956f

Please sign in to comment.