Move Magpie::Constants to Sub::Exporter #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Magpie::Constants was DIYing an Exporter unneccessarily. This fixes it to use Sub::Exporter which is already brought in by Moose. This should close bug #1 reported by tobyink. Additionally we use some of the more advanced Sub::Exporter features to allow adding custom HTTP methods beyond the core set defined by the W3C/IETF. use Magpie::Constants extra_http_methods => [qw(FOO BAR BAZ)] }; or use Magpie::Constants HTTP_METHODS => { extra_http_methods => [qw(FOO BAR BAZ)] }; Should both now work. This closes bug #4 reported by tobyink. Tests are left as a lemma for the reader (currently).
ubu
added a commit
that referenced
this pull request
Mar 3, 2013
Move Magpie::Constants to Sub::Exporter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Magpie::Constants was DIYing an Exporter unneccessarily. This fixes it
to use Sub::Exporter which is already brought in by Moose. This should
close bug #1 reported by tobyink.
Additionally we use some of the more advanced Sub::Exporter features to
allow adding custom HTTP methods beyond the core set defined by the
W3C/IETF.
or
Should both now work. This closes bug #4 reported by tobyink.
Tests are left as a lemma for the reader (currently).