Magpie::Constants exports its constants weirdly.

[tobyink]

Currently use Moose; use Magpie::Constants; works, but use Magpie::Constants; use Moose; does not work. This is down to the highly unconventional way that Magpie::Constants exports its constants.

Why not just...

package Magpie::Constants;
use constant => {
   OK       => 100,
   DECLINED => 199,
   # etc
};
use Sub::Exporter -setup => {
   exports => [qw(OK DECLINED ...)],
   groups  => {
      default => [qw(OK DECLINED ...)],
   },
};
1;

Using Sub::Exporter also allows people to rename the constants easily:

use Magpie::Constants -all => { -prefix => 'MAGPIE_' };
sub GET { return MAGPIE_OK }

Using Sub::Exporter would also behave more sanely in conjunction with namespace::autoclean.

[ubu]

This is just me trying to avoid yet another dependency but I think Sub::Exporter is req'd by Moose anyway so it's silly not to. Assigning this to myself.

[tobyink]

Yes, Moose::Exporter is based on Sub::Exporter.