Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new settings layout #1647

Merged
merged 16 commits into from
Oct 14, 2024
Merged

feat: new settings layout #1647

merged 16 commits into from
Oct 14, 2024

Conversation

0xKheops
Copy link
Contributor

@0xKheops 0xKheops commented Oct 11, 2024 •
edited
Loading

Made all pages pure to ensure any suspense is caught by the main content area, and sidebars don't flicker
ex:

export const AccountAddJsonPage = () => (
  <DashboardLayout sidebar="settings" width="660">
    <Content />
  </DashboardLayout>
)

@0xKheops 0xKheops marked this pull request as ready for review October 14, 2024 03:44
@0xKheops 0xKheops requested a review from chidg October 14, 2024 03:44
chidg
chidg approved these changes Oct 14, 2024
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0xKheops 0xKheops merged commit 6d99495 into dev Oct 14, 2024
6 checks passed
@0xKheops 0xKheops deleted the feat/settings-ui-rework branch October 14, 2024 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xKheops @chidg