Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improved general report reliability #1590

Merged
merged 1 commit into from
Aug 28, 2024
Merged

Conversation

alecdwm
Copy link
Member

@alecdwm alecdwm commented Aug 27, 2024

New report logic:

  • Any analytics event kicks off a general report
  • General report is completed async, so that it doesn't block the kickoff event
  • General report sets up balances and nft subscriptions, then waits a maximum of 30s for those subscriptions to fully hydrate
    • If they take longer than 30s, we continue to build the report with whatever data has hydrated so far
  • Background restarts / browser quits / etc will result in the general report being cancelled,
    but the kickoff event is still sent
  • Once general report is completed, it is stored locally.
    At this point it is primed and ready to go, so background restarts / browser quits / etc won't affect the next step
  • Completed general report is included in the next analytics event, and when this happens it is cleared from storage

@alecdwm alecdwm added the enhancement New feature or request label Aug 27, 2024
@alecdwm alecdwm requested a review from chidg August 27, 2024 07:31
@alecdwm alecdwm self-assigned this Aug 27, 2024
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alecdwm alecdwm merged commit 55ee0b3 into dev Aug 28, 2024
6 checks passed
@alecdwm alecdwm deleted the fix/general-report-reliability branch August 28, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants