Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: nomination pool fees #1178

Merged
merged 11 commits into from
Sep 18, 2024
Merged

Feat: nomination pool fees #1178

merged 11 commits into from
Sep 18, 2024

Conversation

UrbanWill
Copy link
Contributor

@UrbanWill UrbanWill commented Sep 17, 2024 •
edited
Loading

Description

  • Set 3rd Talisman pool polkadot as default for Polkadot
  • Truncate pool name in stake side sheet
  • Display pool commission fee on stake side sheet
  • Display pool commission on nomination pool cards
  • Fix pagination spacing in nomination pool selector modal

Based on this example from Polkadot dashboard.

🗒️ Notes:

A lot of pools are charging 0% commission, this seems odd to me.

🖼️ Screenshots:

Screenshot 2024-09-17 at 16 33 07
Screenshot 2024-09-17 at 16 33 38

@UrbanWill UrbanWill temporarily deployed to portal-storybook (Preview) September 17, 2024 09:40 — with GitHub Actions Inactive
@UrbanWill UrbanWill temporarily deployed to talisman-ui (Preview) September 17, 2024 09:40 — with GitHub Actions Inactive
@UrbanWill UrbanWill changed the title Feat/nom pool fees Feat: nomination pool fees Sep 18, 2024
chidg
chidg approved these changes Sep 18, 2024
View reviewed changes
Copy link
Contributor

@chidg chidg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@UrbanWill UrbanWill temporarily deployed to talisman-ui (Preview) September 18, 2024 08:19 — with GitHub Actions Inactive
@UrbanWill UrbanWill temporarily deployed to portal-storybook (Preview) September 18, 2024 08:19 — with GitHub Actions Inactive
@UrbanWill UrbanWill temporarily deployed to talisman-ui (Preview) September 18, 2024 08:26 — with GitHub Actions Inactive
@UrbanWill UrbanWill temporarily deployed to portal-storybook (Preview) September 18, 2024 08:26 — with GitHub Actions Inactive
@UrbanWill UrbanWill merged commit 162ea79 into main Sep 18, 2024
9 checks passed
@UrbanWill UrbanWill deleted the feat/nom-pool-fees branch September 18, 2024 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chidg chidg chidg approved these changes

@alecdwm alecdwm Awaiting requested review from alecdwm

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UrbanWill @chidg