Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TDOPS-6075): Move jsfc in fork, rename folder json-schema-form-core and some small fixes #5272

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

smouillour
Copy link
Contributor

@smouillour smouillour commented Apr 12, 2024

What is the problem this PR is trying to solve?

What is the chosen solution to this problem?

Please check if the PR fulfills these requirements

  • The PR have used yarn changeset to a request a release from the CI if wanted.
  • The PR commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • Docs have been added / updated (for bug fixes / features)
  • Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 12:58 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 12:58 — with GitHub Actions Inactive
@smouillour smouillour changed the title fix: Move jsfc in fork and rename folder json-schema-form-core fix: Move jsfc in for, rename folder json-schema-form-core and some small fixes Apr 12, 2024
@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 13:01 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 13:01 — with GitHub Actions Inactive
@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 13:01 — with GitHub Actions Inactive
@smouillour smouillour marked this pull request as ready for review April 12, 2024 13:02
Copy link
Contributor

5272

:octocat: Demo is available here

fork/json-schema-form-core/README.md Outdated Show resolved Hide resolved
@smouillour smouillour temporarily deployed to pull_request_unsafe April 12, 2024 13:09 — with GitHub Actions Inactive
"rimraf": "^5.0.5",
"webpack": "^5.90.3"
},
"dependencies": {
"json-refs": "3.0.15",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here: add json-refs and path-brwoserify

@@ -2,7 +2,7 @@
// in the list format.
export default function (titleMap: Array<any>, originalEnum?: any) {
if (!Array.isArray(titleMap)) {
const canonical = [];
const canonical: any = [];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here: add missing type

@@ -1,4 +1,4 @@
import * as JsonRefs from './../lib/json-refs-standalone';
import * as JsonRefs from 'json-refs';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here: Replace local usage by package in node_modules

@@ -16,7 +16,7 @@ const stripNullType = type => {

// Creates an default titleMap list from an enum, i.e. a list of strings.
const enumToTitleMap = enm => {
const titleMap = []; // canonical titleMap format is a list.
const titleMap: any = []; // canonical titleMap format is a list.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here: add missing type

@@ -2,6 +2,7 @@
"extends": "@talend/scripts-config-typescript/tsconfig.json",
"include": ["src/**/*"],
"compilerOptions": {
"noImplicitAny": false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change here: As any has been added to unblock tsc compilation, we need this

output: {
filename: 'index.js',
},
resolve: {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add custom polyfill for json-refs

Copy link
Contributor

github-actions bot commented Apr 12, 2024

Size Change: +167 kB (+1%)

Total Size: 17.6 MB

Filename Size Change
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.54 kB +261 B (+20%) 🚨
./packages/forms/dist/TalendReactForms.js 1.06 MB +158 kB (+18%) ⚠️
./packages/forms/dist/TalendReactForms.min.js 324 kB +95.4 kB (+42%) 🚨
./packages/jsfc/dist/index.js 0 B -86.3 kB (removed) 🏆
ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.15 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.33 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 277 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 595 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 54.6 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 614 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 163 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.25 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.8 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.29 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 806 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 151 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.35 kB 0 B
./packages/components/dist/TalendReactComponents.css 397 kB 0 B
./packages/components/dist/TalendReactComponents.js 4.85 MB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.21 kB 0 B
./packages/components/dist/TalendReactComponents.min.css 212 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 1.29 MB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.29 kB 0 B
./packages/containers/dist/TalendReactContainers.css 2.99 kB 0 B
./packages/containers/dist/TalendReactContainers.js 706 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.4 kB 0 B
./packages/containers/dist/TalendReactContainers.min.css 1.78 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 136 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.45 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 28.1 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 370 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.15 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.css 12.2 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 59.5 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 321 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 1.43 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.49 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.css 203 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 288 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.53 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 67.6 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 39.7 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.css 63.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 33.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 19.1 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 751 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.css 6.28 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 148 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.59 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 50.7 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.25 kB 0 B
./packages/forms/dist/TalendReactForms.css 19.7 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.36 kB 0 B
./packages/forms/dist/TalendReactForms.min.css 6.13 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.39 kB 0 B
./packages/http/dist/TalendHttp.js 24.8 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 5.31 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 26.8 kB 0 B
./packages/icons/dist/react.esm.js 614 kB 0 B
./packages/icons/dist/react.js 654 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 18.3 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 786 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 636 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 14.5 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 0 B -2 B (removed) 🏆
./packages/router-bridge/dist/TalendRouterBridge.js 134 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 21 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.css 2.41 kB 0 B
./packages/stepper/dist/TalendReactStepper.js 97 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 1.27 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.css 1.2 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js 9.37 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 1.31 kB 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 384 B 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.5 kB 0 B
./packages/theme/dist/bootstrap.css 171 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

Copy link
Contributor

Title Lines Statements Branches Functions
assets-api Coverage: 28%
28.4% (25/88) 30.76% (16/52) 21.42% (3/14)
cmf Coverage: 89%
89.2% (1272/1426) 80.36% (618/769) 88.91% (361/406)
cmf-cqrs Coverage: 87%
87.43% (160/183) 70.23% (59/84) 84.21% (48/57)
cmf-router Coverage: 70%
69.23% (135/195) 55.71% (78/140) 56.81% (25/44)
components Coverage: 90%
90.8% (5513/6071) 81.82% (3188/3896) 88.19% (1390/1576)
containers Coverage: 84%
83.71% (1388/1658) 74.81% (692/925) 75.17% (327/435)
dataviz Coverage: 85%
85.44% (323/378) 66.66% (160/240) 75.79% (119/157)
design-system Coverage: 67%
66.88% (1002/1498) 50.38% (527/1046) 54.54% (216/396)
faceted-search Coverage: 85%
85.69% (677/790) 79.31% (303/382) 82.63% (238/288)
flow-designer Coverage: 70%
70.07% (651/929) 66.72% (355/532) 70.92% (200/282)
forms Coverage: 85%
85.4% (1627/1905) 75.53% (920/1218) 84.22% (459/545)
http Coverage: 100%
100% (85/85) 98.07% (51/52) 100% (34/34)
sagas Coverage: 92%
92.3% (24/26) 66.66% (4/6) 50% (2/4)
stepper Coverage: 80%
81.52% (150/184) 59.34% (54/91) 80.85% (38/47)
utils Coverage: 100%
100% (73/73) 90.9% (10/11) 100% (24/24)

@smouillour smouillour changed the title fix: Move jsfc in for, rename folder json-schema-form-core and some small fixes fix: Move jsfc in fork, rename folder json-schema-form-core and some small fixes Apr 12, 2024
@smouillour smouillour enabled auto-merge (squash) April 15, 2024 08:31
@smouillour smouillour merged commit 779fc8c into master Apr 15, 2024
11 checks passed
@smouillour smouillour deleted the smouillour/fix/jsfc-as-fork branch April 15, 2024 08:37
@smouillour smouillour changed the title fix: Move jsfc in fork, rename folder json-schema-form-core and some small fixes fix(TDOPS-6075): Move jsfc in fork, rename folder json-schema-form-core and some small fixes Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants