fix: make it works without timeout

Talend · Jul 24, 2023 · f61ba93 · f61ba93
1 parent 90a5019
commit f61ba93
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 3 deletions.
diff --git a/.changeset/clever-snails-whisper.md b/.changeset/clever-snails-whisper.md
@@ -0,0 +1,5 @@
+---
+'@talend/module-to-cdn': minor
+---
+
+feat: add ace-builds
diff --git a/fork/module-to-cdn/modules.json b/fork/module-to-cdn/modules.json
@@ -155,6 +155,14 @@
       }
     }
   },
+  "ace-builds": {
+    "versions": {
+      ">= 1.10.1": {
+        "development": "/",
+        "production": "/"
+      }
+    }
+  },
   "aframe": {
     "var": "AFRAME",
     "versions": {

diff --git a/packages/forms/src/UIForm/fields/Code/Code.component.tsx b/packages/forms/src/UIForm/fields/Code/Code.component.tsx
@@ -24,13 +24,17 @@ declare const ace: any;
 
 const ReactAce = lazy(() =>
 	assetsApi.getUMD('react-ace').then((mod: any) => {
-		const extUrl = assetsApi.getURL('/src-noconflict/ext-language_tools.js', 'ace-builds');
+		const extUrl = assetsApi.getURL('/src-min-noconflict/ext-language_tools.js', 'ace-builds');
 		ace.config.set('basePath', extUrl.replace('ext-language_tools.js', ''));
 		assetsApi.addScript({ src: extUrl });
 		// wait for ext-language_tools.js to be loaded before return the ace module
 		return new Promise(resolve => {
-			setTimeout(() => {
-				resolve(assetsApi.toDefaultModule(mod.default));
+			const cancel = setInterval(() => {
+				if (ace.require('ace/ext/language_tools')) {
+					clearInterval(cancel);
+					debugger;
+					resolve(assetsApi.toDefaultModule(mod.default));
+				}
 			}, 100);
 		});
 	}),