-
Notifications
You must be signed in to change notification settings - Fork 55
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge branch 'master' into dependabot/npm_and_yarn/babel/preset-env-7…
….23.8
- Loading branch information
Showing
68 changed files
with
1,694 additions
and
2,502 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
--- | ||
'@talend/design-system': patch | ||
--- | ||
|
||
chore: add "section" as an option to the "as" list of possible values of the StackPrimitive component |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
'@talend/ui-playground': patch | ||
'@talend/react-forms': patch | ||
--- | ||
|
||
fix(DFD-536): Fix click on collapsible toggle |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
--- | ||
'@talend/react-faceted-search': major | ||
--- | ||
|
||
TDOPS-5724 - Restyle faceted search to remove bootstrap and use more Design System elements | ||
|
||
# BREAKING CHANGE | ||
- Lot of styling and classes has changed so your overrides might not work anymore | ||
- DOM has changed too so your tests might need to be upgraded | ||
- `tags` type for badges does not exists enymore, use `checkbox` instead as it is the same kind of component but with more possibilities |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
48 changes: 7 additions & 41 deletions
48
packages/faceted-search/src/components/AddFacetPopover/AddFacetPopover.module.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,47 +1,13 @@ | ||
@use '~@talend/bootstrap-theme/src/theme/guidelines' as *; | ||
|
||
@use '~@talend/design-tokens/lib/tokens'; | ||
|
||
$popover-screen-width: tokens.$coral-sizing-maximal; | ||
|
||
.tc-add-facet-popover { | ||
display: flex; | ||
width: $popover-screen-width; | ||
overflow: hidden; | ||
|
||
:global(.tc-tooltip-header) { | ||
width: $popover-screen-width; | ||
align-items: center; | ||
font-weight: 800; | ||
min-width: auto; | ||
} | ||
|
||
:global(.tc-tooltip-body) { | ||
margin-right: 0; | ||
margin-left: 0; | ||
padding: 0; | ||
|
||
:global(.tc-tooltip-content) { | ||
flex-direction: column; | ||
min-height: 0; | ||
padding: 1rem 0; | ||
} | ||
} | ||
|
||
&-filter-empty { | ||
padding: tokens.$coral-spacing-s; | ||
display: block; | ||
text-align: center; | ||
font-style: italic; | ||
} | ||
|
||
&-row-container { | ||
overflow-y: auto; | ||
width: tokens.$coral-sizing-xxxl; | ||
} | ||
|
||
button { | ||
width: 100%; | ||
overflow-wrap: anywhere; | ||
text-align: left; | ||
} | ||
.tc-add-facet-popover-items { | ||
button { | ||
width: 100%; | ||
white-space: break-spaces; | ||
text-align: left; | ||
} | ||
} |
51 changes: 15 additions & 36 deletions
51
...h/src/components/AddFacetPopover/AddFacetPopoverHeader/AddFacetPopoverHeader.component.js
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,63 +1,42 @@ | ||
/* eslint-disable jsx-a11y/no-autofocus */ | ||
import { createRef, useCallback, useEffect, useMemo, useRef, useState } from 'react'; | ||
import PropTypes from 'prop-types'; | ||
import isNull from 'lodash/isNull'; | ||
import PropTypes from 'prop-types'; | ||
|
||
import { ButtonIcon } from '@talend/design-system'; | ||
import { FilterBar, getTheme, Rich } from '@talend/react-components'; | ||
|
||
import { getTabIndex } from '../addFacetPopover.utils'; | ||
import cssModule from './AddFacetPopoverHeader.module.scss'; | ||
|
||
const theme = getTheme(cssModule); | ||
import { ButtonTertiary, Form } from '@talend/design-system'; | ||
|
||
export const AddFacetPopoverHeader = ({ | ||
category, | ||
onCategoryChange, | ||
id, | ||
resetFilter, | ||
onFilter, | ||
filterValue, | ||
t, | ||
isFocusable, | ||
}) => ( | ||
<Rich.Layout.Header className={theme('tc-add-facet-popover-header')} id={`${id}-header`}> | ||
<div id={`${id}-header`}> | ||
{!isNull(category) && ( | ||
<div className={theme('tc-add-facet-popover-header-category')}> | ||
<ButtonIcon | ||
icon="chevron-left" | ||
size="S" | ||
onClick={() => onCategoryChange(null)} | ||
tabIndex={getTabIndex(isFocusable)} | ||
> | ||
{t('ADD_FACET_FILTER_BACK', 'Back')} | ||
</ButtonIcon> | ||
<span className={theme('tc-add-facet-popover-header-category-title')}>{category}</span> | ||
</div> | ||
<ButtonTertiary | ||
data-test="add-facet-popover-header-goback" | ||
data-testid="add-facet-popover-header-goback" | ||
icon="chevron-left" | ||
size="S" | ||
onClick={() => onCategoryChange(null)} | ||
> | ||
{t('ADD_FACET_FILTER_BACK', 'Back')} | ||
</ButtonTertiary> | ||
)} | ||
<FilterBar | ||
autoFocus={false} | ||
className={theme('tc-add-facet-popover-filter')} | ||
dockable={false} | ||
docked={false} | ||
iconAlwaysVisible | ||
<Form.Search | ||
id={`${id}-filter`} | ||
placeholder={t('ADD_FACET_FILTER_PLACEHOLDER', 'Find a filter')} | ||
onToggle={resetFilter} | ||
onFilter={onFilter} | ||
onChange={onFilter} | ||
value={filterValue} | ||
disabled={!isFocusable} | ||
/> | ||
</Rich.Layout.Header> | ||
</div> | ||
); | ||
|
||
AddFacetPopoverHeader.propTypes = { | ||
category: PropTypes.string, | ||
onCategoryChange: PropTypes.func.isRequired, | ||
id: PropTypes.string.isRequired, | ||
resetFilter: PropTypes.func.isRequired, | ||
onFilter: PropTypes.func.isRequired, | ||
filterValue: PropTypes.string.isRequired, | ||
isFocusable: PropTypes.bool.isRequired, | ||
t: PropTypes.func.isRequired, | ||
}; |
38 changes: 0 additions & 38 deletions
38
...ch/src/components/AddFacetPopover/AddFacetPopoverHeader/AddFacetPopoverHeader.module.scss
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.