Skip to content

Commit

Permalink
fix(ARCH-662): request security issue (#4650)
Browse files Browse the repository at this point in the history
  • Loading branch information
jmfrancois authored Mar 22, 2023
1 parent 443d132 commit 20436dd
Show file tree
Hide file tree
Showing 7 changed files with 57 additions and 630 deletions.
5 changes: 5 additions & 0 deletions .changeset/clean-grapes-invite.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@talend/scripts-publish-local': minor
---

feat: use npx to execute verdaccio.
3 changes: 1 addition & 2 deletions tools/scripts-publish-local/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,7 @@
"dependencies": {
"cross-spawn": "^7.0.3",
"generate-password": "^1.7.0",
"rimraf": "^3.0.2",
"verdaccio": "^5.20.1"
"rimraf": "^3.0.2"
},
"author": "Talend Frontend <[email protected]> (http://www.talend.com)",
"license": "Apache-2.0",
Expand Down
1 change: 1 addition & 0 deletions tools/scripts-publish-local/src/cmd.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
/* eslint-disable-next-line import/no-extraneous-dependencies */
const spawn = require('cross-spawn');
const fs = require('fs');
Expand Down
1 change: 1 addition & 0 deletions tools/scripts-publish-local/src/git.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
const os = require('os');
const cmd = require('./cmd');

Expand Down
1 change: 1 addition & 0 deletions tools/scripts-publish-local/src/npm.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
const fs = require('fs');
const os = require('os');
const path = require('path');
Expand Down
3 changes: 2 additions & 1 deletion tools/scripts-publish-local/src/verdaccio.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
/* eslint-disable no-console */
const fs = require('fs');
const os = require('os');
const rimraf = require('rimraf');
Expand Down Expand Up @@ -53,7 +54,7 @@ async function start() {
console.log('verdaccio.start');
return new Promise(resolve => {
generateConfig();
cmd.run(`verdaccio --config ${VERDACCIO_CONFIG_FILE}`, {
cmd.run(`npx --yes verdaccio --config ${VERDACCIO_CONFIG_FILE}`, {
interactive: verdaccio => {
verdaccio.stdout.on('data', data => {
if (data.includes('http address')) {
Expand Down
673 changes: 46 additions & 627 deletions yarn.lock

Large diffs are not rendered by default.

0 comments on commit 20436dd

Please sign in to comment.