Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps): bump org.testng:testng from 6.4 to 7.9.0 #53

Merged
merged 2 commits into from
Feb 20, 2024
Merged

chore(deps): bump org.testng:testng from 6.4 to 7.9.0 #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aaec790
chore(deps): bump org.testng:testng from 6.4 to 7.9.0
dependabot[bot] Feb 20, 2024
4cbc598
fix: testng
benfonty Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ buildscript {
// workaround for reckon issue with Java 8
grgitVersion = "5.2.2"

testngVersion = "6.4"
testngVersion = "7.9.0"
jakartaVersion = "6.0.0"
jakartaValidationVersion = "3.0.2"

Expand Down
9 changes: 6 additions & 3 deletions scim2-sdk-common/src/test/java/com/bettercloud/scim2/common/DiffTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ public void testDiffSingularAttribute() throws Exception
op.apply(source);
}
removeNullNodes(target);
assertEquals(source, target);
// Force testng to use object equals instead of iterator one, because the attributes are not in the same order
assertEquals((Object) source, (Object) target);
}

/**
Expand Down Expand Up @@ -324,7 +325,8 @@ public void testDiffMultiValuedAttribute() throws Exception
" not in target photo array " + targetPhotos);
}
}
assertEquals(source, target);
// Force testng to use object equals instead of iterator one, because the attributes are not in the same order
assertEquals((Object) source, (Object) target);
}

/**
Expand Down Expand Up @@ -496,7 +498,8 @@ public void testDiffMultiValuedComplexAttribute() throws Exception
op.apply(source);
}
removeNullNodes(target);
assertEquals(source, target);
// Force testng to use object equals instead of iterator one, because the attributes are not in the same order
assertEquals((Object) source, (Object) target);
}

/**
Expand Down
6 changes: 4 additions & 2 deletions scim2-sdk-common/src/test/java/com/bettercloud/scim2/common/JsonUtilsTestCase.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -802,7 +802,8 @@ public void testAddReplaceRoot() throws IOException, ScimException

JsonUtils.addValue(Path.root(), resource, value);

assertEquals(resource, expectedAddResult);
// Force testng to use object equals instead of iterator one, because the attributes are not in the same order
assertEquals((Object) resource, (Object) expectedAddResult);

JsonNode expectedReplaceResult = JsonUtils.getObjectReader().
readTree("{\n" +
Expand Down Expand Up @@ -832,7 +833,8 @@ public void testAddReplaceRoot() throws IOException, ScimException

JsonUtils.replaceValue(Path.root(), resource, value);

assertEquals(resource, expectedReplaceResult);
// Force testng to use object equals instead of iterator one, because the attributes are not in the same order
assertEquals((Object) resource, (Object) expectedReplaceResult);
}


Expand Down
Loading