Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Location Fields #537

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Nginearing
Copy link
Contributor

  • Add location (text line) fields

@Nginearing
Copy link
Contributor Author

Nginearing commented Oct 9, 2024

Sorry, I'm stupid lol. I thought that CyanVoxel said about making a pull request or something to the 9.4 branch instead, I should I switch this to the main branch? (and obviously sync my branch to match the main branch, before doing so) ?

@seakrueger
Copy link
Contributor

seakrueger commented Oct 9, 2024

Yes, per 332 merge Discord announcement
Unless this qualifies as a "teeny tiny QoL feature", but IMO while small doesn't qualify and I don't know if another 9.4 release is planned

- Add Location (Text Line) Fields
@Nginearing Nginearing changed the base branch from Alpha-v9.4 to main October 9, 2024 22:53
@seakrueger
Copy link
Contributor

The json library is no longer used on main, new fields should be added under library/alchemy/fields.py

@Nginearing
Copy link
Contributor Author

The json library is no longer used on main, new fields should be added under library/alchemy/fields.py

Of course, I just clicked through the folders, I didn't even look at the folder names, oops.

@Nginearing
Copy link
Contributor Author

Nginearing commented Oct 9, 2024

I think that's correct now.

@CyanVoxel
Copy link
Member

This is indeed the correct branch for new features at the moment.

While location fields would be beneficial (as we chatted about a few weeks ago) I think the field would make more sense to hold actual EXIF-style GPS location data rather than just be a cosmetic text field. Custom names for fields are coming in the future too, so there wouldn't be a need for hardcoded names for fields such as this when that eventually lands.

@CyanVoxel CyanVoxel added the TagStudio: Library Relating to the TagStudio library system label Oct 10, 2024
@Nginearing
Copy link
Contributor Author

Nginearing commented Oct 10, 2024

This is indeed the correct branch for new features at the moment.

While location fields would be beneficial (as we chatted about a few weeks ago) I think the field would make more sense to hold actual EXIF-style GPS location data rather than just be a cosmetic text field. Custom names for fields are coming in the future too, so there wouldn't be a need for hardcoded names for fields such as this when that eventually lands.

How about: TagStudio shows location (gps) metadata alongside the usual Date Created and Date Modified metadata, what you're describing, sounds similar to the ability to modify metadata which afaik has been mentioned in an issue before.

@CyanVoxel
Copy link
Member

How about: TagStudio shows location (gps) metadata alongside the usual Date Created and Date Modified metadata, what you're describing, sounds similar to the ability to modify metadata which afaik has been mentioned in an issue before.

This is something I would like also like, along with showing any other EXIF data in a similar manner. This PR/feature request would more so be for adding custom GPS/location data for your own purposes and/or having multiple GPS values per file entry. As I think about it though, I'm struggling to come up with practical use cases for this... If @Nginearing is okay with just having the EXIF data display with the potential for EXIF editing further down the line, then I'm okay with that too.

@Nginearing
Copy link
Contributor Author

I'll get started on programming the implementation to show the gps coordinates exif data.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
TagStudio: Library Relating to the TagStudio library system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants