Add support for mksh #115
Open
Add support for mksh #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`frum init` produces an error about not being able to infer the shell when ran under mksh. From looking at frum's source and documentation, the `__frumcd` shell function and the `eval` and `frum init` commands for bash all seem like they will work just fine with mksh. I added mksh alongside bash and sh and rebuilt frum and everything is working well for me. I do not currently have access to other ksh derivatives to test with, and I am not sure of the current state of ksh derivative support in the "shell" crate. But this simple change has me up and running and enjoying frum.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
frum initproduces an error about not being able to infer the shellwhen ran under mksh.
From looking at frum's source and documentation, the
__frumcdshell function and the
evalandfrum initcommands for bash allseem like they will work just fine with mksh. I added mksh alongside
bash and sh and rebuilt frum and everything is working well for me.
I do not currently have access to other ksh derivatives to test with,
and I am not sure of the current state of ksh derivative support in the
"shell" crate. But this simple change has me up and running and enjoying
frum.
changelog: Add support for mksh by leveraging the existing bash/sh shell functionality