Fix/latest versions security #88
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jvanderkroon could you please review this new patch to make sure it matches your initial intention? |
|
also related to #63 and TYPO3-Caretaker/caretaker_instance#56 |
|
NOT NOT MERGE (yet) Jigal suggested some changes/additions via mail and i'm going to add some more tests to cover thoses cases. |
IchHabRecht
requested changes
Jul 31, 2017
|
Jigals comment about the versioning
|
|
i'm going to extend the tests to cover these cases. |
IchHabRecht
reviewed
Jun 23, 2018
| $stable = array(); | ||
| $security = array(); | ||
| foreach ($releases as $major => $details) { | ||
| if (is_array($details) && !empty($details['latest'])) { |
There was a problem hiding this comment.
if (!empty($details['latest'])) is sufficient here
| $max[$major] = $details['latest']; | ||
| } | ||
|
|
||
| if (is_array($details) && !empty($details['stable'])) { |
There was a problem hiding this comment.
if (!empty($details['stable'])) is sufficient here
| if (is_array($details) && !empty($details['stable'])) { | ||
| $stable[$major] = $details['stable']; | ||
| } | ||
| if (is_array($details) && is_array($details['releases'])) { |
There was a problem hiding this comment.
if (!empty($details['releases'])) is sufficient here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did refactor Jorgen/Jigals patch from #76 and added a basic unit test.
As I didnt get the intention of the "$major > $latestLts" comparsion, I just removed that part.
Also, if a major version just has regular releases, but no security releases yet, the "latest security" version would fallback to the PATCH version ".0".