Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a helper method to simplify the verification of dependencies #273

Closed

Conversation

andreaslausen
Copy link

I created a method that really simpilifies the verification of dependencies at the assembly level. You just need to write var rule = Dependencies.Check(sourceAssembly, [targetAssembly1, targetAssembly2]), call rule.Check and you're done.

It would be awesome if this method would be integrated into ArchUnitNET.

@andreaslausen andreaslausen force-pushed the checkdependencies_helper_method branch from 9d8595f to d9116a3 Compare June 17, 2024 11:12
@thojaw
Copy link

thojaw commented Jul 1, 2024

I like the idea, not sure though if such methods should be part of the core library, you could have many more and they could be part of your own Extensions. That would be different if you'd access some internal classes, for example. But hey, I'm just some random guy, not a maintainer :)

@alexanderlinne
Copy link
Collaborator

Hi @andreaslausen, thank you for your PR. I'd agree with @thojaw here, since this would add a function that just contains another fluent expression I do not think this would belong in the core library. Additionally there is #130 which, although we cannot provide an ETA for the feature, make it possible to write something along the lines of Assemblies().That().Are(sourceAssembly).Should().NotDependOnAnyAssembliesThat().Are([targetAssembly1, targetAssembly2]).Check(architecture)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants