Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TOP-67 fix 회원가입 이후 Splash 아이콘이 표시되었다가 메인으로 이동되는 현상 수정 #101

Merged
merged 3 commits into from
Oct 2, 2023

Conversation

cwj-c
Copy link
Member

@cwj-c cwj-c commented Sep 17, 2023

Explain this Pull Request 🙏

  • 회원가입 이후 Splash 아이콘이 표시되었다가 메인으로 이동되는 현상 수정

What has changed? 🤔

  • 변경 사항
    • splash visible 처리

Screenshot 📸

Test Checklist 🚩

 - 현재 맥북의 가상기기에서는 재현이 안되어서, 다른 기기에서 테스트 필요
 - 실제 Topic 배열 상 idx가 아닌 Topic 데이터의 idx를 전달
 - ketwordIdx가 아닌 idx
@@ -48,6 +49,7 @@ class SplashActivity : AppCompatActivity() {
private fun observeViewModel() {
val signupResult = registerForActivityResult(ActivityResultContracts.StartActivityForResult()) {
Log.d("TAG", "signupResult => $it")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

완성된 부분이라면 제거하는 것이 어떠한가요?

Suggested change
Log.d("TAG", "signupResult => $it")

Copy link
Collaborator

@taewooyo taewooyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good~!

@cwj-c cwj-c merged commit 486c4f1 into develop Oct 2, 2023
4 checks passed
@cwj-c cwj-c deleted the fix/TOP-67_signup_after_splash_visible branch October 2, 2023 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants