fix: updated legacy boxes #834
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
clegirar
requested changes
Jan 3, 2024
There was a problem hiding this comment.
Sorry by advance for all Same here 👍 comments ^^
Except the little missbehavior on styles everything is good 👍 Good job for that, really 👏
Maybe you can check how you can rename your commits to respect the name convention on commits ? If you want some resources don't hesitate to ping me
Don't hesitate to ask questions in discord if you want 👍
thomarnauld
commented
Jan 8, 2024
There was a problem hiding this comment.
I completed the revisions based on the comments. I noticed regressions in the rendering of certain boxes which come from packages/components/boxes/box.tsx
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
* feat(dapp-store): add explorer category add staking category * feat(dapp-store): add Calc Finance
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
* feat: add a period filter (only front) * feat(marketplace-period-filter): Add period filter to marketplace screen Add a period filter to the marketplace screen in order to allow users to filter collections based on a specific time period. The period filter will be implemented using a dropdown menu with options for different time periods, such as "Last 10 minutes", "Last 1 hour", "Last 6 hours", etc. The selected time period will be used to retrieve collections that were created within that period. Changes made in this commit: - Added a new optional field "period_in_minutes" to the "GetCollectionsRequest" message in the "marketplace.proto" file. - Added a new state variable "timePeriod" to the "UIStates" interface in the "marketplaceFilters.ts" file. - Added a new array "marketplacePeriodItems" to define the available time period options in the "marketplaceFilters.ts" file. - Added a new action "setTimePeriod" to update the selected time period in the * fix: remove console.log --------- Co-authored-by: Eng. Juan Combetto <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
* feat: add an input to modify an owned nft listing price * feat: add update price logic Signed-off-by: Norman Meier <[email protected]> --------- Signed-off-by: Norman Meier <[email protected]> Co-authored-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
* fix: add a Context to controls wallet funds and wallet connected * fix: link to squid instead of kado Signed-off-by: Norman Meier <[email protected]> --------- Signed-off-by: Norman Meier <[email protected]> Co-authored-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
|
i will close this PR. Pls go check the new >>> #897 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I created this new branch to validate the CI. I commented out the variables not used in the code (Legacy) in case we need them in the future. I will delete the comments once this first test is validated. THANKS