Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tns): avatar and cover image upload previews #782

Merged
merged 1 commit into from
Jan 15, 2024
Merged

feat(tns): avatar and cover image upload previews #782

merged 1 commit into from
Jan 15, 2024

Conversation

omniwired
Copy link
Collaborator

No description provided.

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit d235a38
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/65a5ac29715186000892888e
😎 Deploy Preview https://deploy-preview-782--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 28, 2023 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit d235a38
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/65a5ac29f8369c0008af9a15
😎 Deploy Preview https://deploy-preview-782--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omniwired omniwired force-pushed the feat/edit-profile-v2 branch 2 times, most recently from e839ee7 to dfb2a17 Compare November 28, 2023 06:15
@omniwired omniwired marked this pull request as ready for review November 28, 2023 09:13
@omniwired omniwired closed this Nov 28, 2023
@omniwired omniwired reopened this Nov 29, 2023
@omniwired omniwired marked this pull request as draft November 29, 2023 00:36
@omniwired omniwired marked this pull request as ready for review November 29, 2023 02:08
@zxxma
Copy link
Collaborator

zxxma commented Nov 29, 2023

Bug report :
I think there is something strange with pictures compression,
Looks like compressing to much and pixelizing (both avatar and header), not only the preview, but minted content.
Can you double-check ?

(otherwise, it's nice! 👍)

@omniwired omniwired force-pushed the feat/edit-profile-v2 branch 2 times, most recently from 08933c3 to 8396a43 Compare November 29, 2023 02:43
@zxxma
Copy link
Collaborator

zxxma commented Nov 29, 2023

Thanks for the fix 👌
LGTM 👍

WaDadidou
WaDadidou previously approved these changes Nov 30, 2023
View reviewed changes
Copy link
Collaborator

@WaDadidou WaDadidou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@n0izn0iz
Copy link
Collaborator

n0izn0iz commented Nov 30, 2023 •
edited
Loading

This can happen if a file is replicated for the first time:
Before timeout, would be better to show a loader on a black background I think
Screenshot 2023-11-30 at 20 02 14

After timeout
Screenshot 2023-11-30 at 21 08 04

Also would be nice that the banner preview take the full width

@WaDadidou WaDadidou force-pushed the feat/edit-profile-v2 branch 2 times, most recently from d5e2751 to 2c44c9f Compare January 15, 2024 15:54
@WaDadidou
Copy link
Collaborator

WaDadidou commented Jan 15, 2024 •
edited
Loading

This can happen if a file is replicated for the first time: Before timeout, would be better to show a loader on a black background I think Screenshot 2023-11-30 at 20 02 14

After timeout Screenshot 2023-11-30 at 21 08 04

Also would be nice that the banner preview take the full width

======> Fixed

clegirar
clegirar reviewed Jan 15, 2024
View reviewed changes
Copy link
Collaborator

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Else i think everything is okay 👍

packages/components/teritoriNameService/NameDataForm.tsx Show resolved Hide resolved
@WaDadidou WaDadidou force-pushed the feat/edit-profile-v2 branch 5 times, most recently from a5c342b to 0d80bac Compare January 15, 2024 19:32
n0izn0iz
n0izn0iz requested changes Jan 15, 2024
View reviewed changes
packages/components/OptimizedImage.tsx Outdated Show resolved Hide resolved
@n0izn0iz n0izn0iz changed the title feat(TeritoriNameService): Add avatar and cover image upload previews feat(tns): avatar and cover image upload previews Jan 15, 2024
@n0izn0iz n0izn0iz merged commit 4bb9255 into main Jan 15, 2024
16 checks passed
@n0izn0iz n0izn0iz deleted the feat/edit-profile-v2 branch January 15, 2024 22:28
ChiragPansuriya-iView pushed a commit that referenced this pull request Jan 31, 2024
@omniwired @ChiragPansuriya-iView
feat(tns): avatar and cover image upload previews (#782)
c8f7950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clegirar clegirar clegirar left review comments

@WaDadidou WaDadidou WaDadidou left review comments

@n0izn0iz n0izn0iz n0izn0iz requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@omniwired @zxxma @n0izn0iz @WaDadidou @clegirar