Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upload video button and new video thumbnail #762

Merged
merged 11 commits into from
Nov 25, 2023
Merged

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 22, 2023

Add upload video button in social feed's video tab

button: https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=14682-287916&mode=design&t=CsyFyilB8z6wJh0z-4

flow: https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=14683-289637&mode=design&t=CsyFyilB8z6wJh0z-4

And rework video thumbnail to use the new description field like in https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=20319-162643&mode=design&t=CsyFyilB8z6wJh0z-4


Video upload modal

image

Video in Jungle Feed

image

Videos posted as usualy (Through NewsFeedInput) have now the VideoNote PostCategory
image

X - No duration because onloadedmetadata is not triggered here :

video.onloadedmetadata = () => {

X - Have to generate thumbnail image and use it as thumbnail on Video upload if no image provided by the user.
Here : https://github.com/TERITORI/teritori-dapp/blob/1130a8ad5718fc7ced4597b323322616e4c09052/packages/utils/video/index.ts#L24-L23

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit ebc004d
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6562259f69d1050008aac643
😎 Deploy Preview https://deploy-preview-762--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 22, 2023

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit ebc004d
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/6562259f0dcbaf0008974b6a
😎 Deploy Preview https://deploy-preview-762--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou force-pushed the feat/video-feed branch 3 times, most recently from a43b300 to f2fc6d7 Compare November 23, 2023 10:22
@WaDadidou WaDadidou self-assigned this Nov 23, 2023
@WaDadidou WaDadidou changed the title feat: Videos upload Add Upload Video Button/Flow and rework video card Nov 23, 2023
@WaDadidou WaDadidou force-pushed the feat/video-feed branch 7 times, most recently from 5b04cf5 to 6f43759 Compare November 24, 2023 16:52
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz n0izn0iz changed the title Add Upload Video Button/Flow and rework video card feat: upload video button and new video thumbnail Nov 25, 2023
@n0izn0iz n0izn0iz merged commit 3e2feb9 into main Nov 25, 2023
12 checks passed
@n0izn0iz n0izn0iz deleted the feat/video-feed branch November 25, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants