-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: upload video button and new video thumbnail #762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
force-pushed
the
feat/video-feed
branch
3 times, most recently
from
November 23, 2023 10:22
a43b300
to
f2fc6d7
Compare
omniwired
reviewed
Nov 23, 2023
omniwired
reviewed
Nov 23, 2023
WaDadidou
changed the title
feat: Videos upload
Add Upload Video Button/Flow and rework video card
Nov 23, 2023
WaDadidou
force-pushed
the
feat/video-feed
branch
7 times, most recently
from
November 24, 2023 16:52
5b04cf5
to
6f43759
Compare
WaDadidou
force-pushed
the
feat/video-feed
branch
from
November 24, 2023 17:05
45d8aeb
to
a6a0b9a
Compare
Signed-off-by: Norman Meier <[email protected]>
n0izn0iz
force-pushed
the
feat/video-feed
branch
from
November 25, 2023 16:49
97a1464
to
ebc004d
Compare
n0izn0iz
changed the title
Add Upload Video Button/Flow and rework video card
feat: upload video button and new video thumbnail
Nov 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add upload video button in social feed's video tab
button: https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=14682-287916&mode=design&t=CsyFyilB8z6wJh0z-4
flow: https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=14683-289637&mode=design&t=CsyFyilB8z6wJh0z-4
And rework video thumbnail to use the new description field like in https://www.figma.com/file/WLEMAQXohIwBEPL5lsRrvK/Teritori---dApp?type=design&node-id=20319-162643&mode=design&t=CsyFyilB8z6wJh0z-4
Video upload modal
Video in Jungle Feed
Videos posted as usualy (Through NewsFeedInput) have now the VideoNote PostCategory
X - No duration because
onloadedmetadata
is not triggered here :teritori-dapp/packages/utils/video/index.ts
Line 9 in 1130a8a
X - Have to generate thumbnail image and use it as thumbnail on Video upload if no image provided by the user.
Here : https://github.com/TERITORI/teritori-dapp/blob/1130a8ad5718fc7ced4597b323322616e4c09052/packages/utils/video/index.ts#L24-L23