Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Stick Article creation Toolbar at bottom #741

Closed
wants to merge 1 commit into from

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 14, 2023

I wouldn't change the Toolbar emplacement in the container arborescence to avoid passing a ton of props from FeedNewArticleScreen to RichText.
But my solution seems messy

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit b9b2043
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6553a4edad309300080c6b0f
😎 Deploy Preview https://deploy-preview-741--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 14, 2023

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit b9b2043
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/6553a4ed62f1fd0008dbfea9
😎 Deploy Preview https://deploy-preview-741--testitori.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou changed the title fix: add the possibility to get the scroll position of ScreenContaine… fix: Stick Article creation Toolbar at bottom Nov 14, 2023
@WaDadidou WaDadidou force-pushed the fix/article-creation-stick-toolbar branch 2 times, most recently from a647872 to 9e7b027 Compare November 14, 2023 16:42
@WaDadidou WaDadidou force-pushed the fix/article-creation-stick-toolbar branch from 9e7b027 to b9b2043 Compare November 14, 2023 16:48
@n0izn0iz n0izn0iz assigned n0izn0iz and WaDadidou and unassigned n0izn0iz Nov 16, 2023
@n0izn0iz
Copy link
Collaborator

We'll redo the article creation soon and @WaDadidou is not proud of this so closing

@n0izn0iz n0izn0iz closed this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants