Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unused exports #700

Merged
merged 11 commits into from
Sep 28, 2023
Merged

chore: remove unused exports #700

merged 11 commits into from
Sep 28, 2023

Conversation

clegirar
Copy link
Collaborator

No description provided.

@clegirar clegirar self-assigned this Sep 12, 2023
@netlify
Copy link

netlify bot commented Sep 12, 2023 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit d23e87d
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/6515953ff293530008486bb3
😎 Deploy Preview https://deploy-preview-700--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Sep 12, 2023 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit d23e87d
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/6515953f9cfc0800088f8f39
😎 Deploy Preview https://deploy-preview-700--teritori-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@clegirar clegirar changed the title WIP: fix all unused exports from packages/components WIP: fix all unused exports Sep 12, 2023
@WaDadidou
Copy link
Collaborator

WaDadidou commented Sep 21, 2023 •
edited
Loading

Could you rename RiotGameScreen.web.tsx as RiotGameScreen.tsx since this file is removed: https://github.com/TERITORI/teritori-dapp/blob/ce0d7ea427b993e0dc4f1c8a8006bb821933d445/packages/screens/RiotGame/RiotGameScreen.tsx
(And change the import in Navigator.tsx)

@WaDadidou
Copy link
Collaborator

WaDadidou commented Sep 21, 2023 •
edited
Loading

Here

teritori-dapp/packages/components/socialFeed/SocialActions/ShareButton.tsx

Line 10 in 68f8f69

interface FeedPostShareModalProps {
could you rename FeedPostShareModalProps as ShareButtonProps (Or remove this interface, cause there is only one property), since this file is removed: https://github.com/TERITORI/teritori-dapp/blob/ce0d7ea427b993e0dc4f1c8a8006bb821933d445/packages/components/socialFeed/SocialActions/FeedPostShareModal.tsx

@WaDadidou
Copy link
Collaborator

Please fix lint-and-build and update the branch with origin/main

WaDadidou
WaDadidou requested changes Sep 21, 2023
View reviewed changes
packages/screens/DAppStore/apps/toripunks/query/useHistoryData.ts Show resolved Hide resolved
packages/screens/DAppStore/apps/toripunks/query/userHistoryMock.ts Show resolved Hide resolved
packages/components/gradientText/index.ts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got this warning : Attempted import error: 'GradientType' is not exported from './GradientText'.
(I don't know why, it doesn't make sense)

Since you do this modif, you may can do the same thing for all components with a web version. You missed this one: https://github.com/TERITORI/teritori-dapp/tree/68f8f691930c3a669e9cc037392694edacfdce30/packages/components/fileUploader

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Which tool give you this error ? Because i have nothing that say that ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was happening when trying to build the project

@clegirar
fix: all unused exports from packages/components
57b6296 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/hooks
cf5afd3 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/context
3d50df6 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/screens
6066f68 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/utils
6aea35d 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/store
212f792 
Signed-off-by: clegirar <[email protected]>
@clegirar
fix: all unused exports from packages/networks
d2d53db 
Signed-off-by: clegirar <[email protected]>

WIP: fix all unused exports from packages/networks

Signed-off-by: clegirar <[email protected]>
@clegirar clegirar force-pushed the fix/delete-all-unused-exports branch 2 times, most recently from d950096 to f7f3666 Compare September 22, 2023 07:20
@clegirar
Copy link
Collaborator Author

If it's possible i want to rebase on main after merging Audio Player to have just one nightmare to resolve conflicts 🙃

omniwired
omniwired previously approved these changes Sep 24, 2023
View reviewed changes
@n0izn0iz n0izn0iz changed the title WIP: fix all unused exports chore: remove unused exports Sep 28, 2023
@n0izn0iz n0izn0iz merged commit 9208f1f into main Sep 28, 2023
12 checks passed
@n0izn0iz n0izn0iz deleted the fix/delete-all-unused-exports branch September 28, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@omniwired omniwired omniwired left review comments

@WaDadidou WaDadidou WaDadidou requested changes

Assignees

@clegirar clegirar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clegirar @WaDadidou @omniwired @n0izn0iz