fix: refacto dropdowns #697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
However i just fix the behavior of the component, but not the refacto of it. |
WaDadidou
requested changes
Sep 12, 2023
WaDadidou
force-pushed
the
fix/refacto-dropdowns
branch
from
4773358
to
55d8221
Compare
WaDadidou
previously approved these changes
Sep 27, 2023
WaDadidou
force-pushed
the
fix/refacto-dropdowns
branch
4 times, most recently
from
2abf1ab
to
ae633a1
Compare
clegirar
force-pushed
the
fix/refacto-dropdowns
branch
from
ae633a1
to
43128a0
Compare
hthieu1110
reviewed
Oct 30, 2023
| const dropdownRef = useRef<View>(null); | ||
|
|
||
| return ( | ||
| <View style={{ position: "relative" }}> |
There was a problem hiding this comment.
Seems that by default all the View has position relative
WaDadidou
force-pushed
the
fix/refacto-dropdowns
branch
from
43128a0
to
6611cff
Compare
Signed-off-by: clegirar <[email protected]>
Signed-off-by: clegirar <[email protected]>
n0izn0iz
force-pushed
the
fix/refacto-dropdowns
branch
from
6611cff
to
99a5b55
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This
tree dotscomponents were not consistant, especially when we clicked outside of the dropdown, all dropdowns had not same behaviorSo i gave it back consistant, for the first one (first screen) was good and works well !
For the second one (second screen), you probably just forgot to put the ref in the parent view of the dropdown
For the last one (last image), it was just not implemented :)
Signed-off-by: clegirar [email protected]