fix: Enhance SelectInput and DAOSelector #669
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
WaDadidou
force-pushed
the
fix/DAOSelector
branch
2 times, most recently
from
3a8bfae
to
3bd6191
Compare
omniwired
previously approved these changes
Aug 16, 2023
WaDadidou
force-pushed
the
fix/DAOSelector
branch
2 times, most recently
from
2bf7627
to
9e2a1b0
Compare
WaDadidou
force-pushed
the
fix/DAOSelector
branch
from
9e2a1b0
to
255dfac
Compare
n0izn0iz
requested changes
Aug 17, 2023
Comment on lines
+96
to
+98
| export const useNSPrimaryAliases = (userIds: string[] | undefined) => { | ||
| const { data, ...other } = useQuery( | ||
| nsPrimaryAliasQueryKey(userIds?.map((id) => id.slice(-3)).toString()), |
There was a problem hiding this comment.
this breaks caching, please use useNSPrimaryAlias deeper in the component tree
Comment on lines
+293
to
+295
| inputIconContainer: { | ||
| marginLeft: layout.padding_x1_5, | ||
| }, |
There was a problem hiding this comment.
please don't use stylesheet.Create or add new fields in stylesheet.Create, this creates potential undetectable deadcode and has no performance impact contrary to popular belief
if you want to define constant styles to prevent re-renders on memoized components, use something like
export const SomeComponent: React.FC = () => {
return <View style={inputIconContainerStyle} />
}
const inputIconContainerStyle: ViewStyle = {
marginLeft: layout.padding_x1_5,
}| @@ -71,7 +71,6 @@ export const TNSManageScreen: React.FC<TNSManageScreenProps> = ({ | |||
| </BrandText> | |||
|
|
|||
| <DAOSelector | |||
| value={selectedDAOId} | |||
There was a problem hiding this comment.
are you sure about this change? uncontrolled inputs can be a pain
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DAOSelector.SelectInputand add the possibility to enters a value to search in theSelectInputlist (Not effective forDAOSelector, the image is just an example)Before, we used
@react-native-picker/pickerSee
teritori-dapp/packages/components/dao/DAOSelector.tsx
Line 18 in 99619c9
And
teritori-dapp/packages/components/inputs/SelectInput.tsx
Line 52 in 99619c9