Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: cosmos multisig #637

Merged
merged 181 commits into from
Oct 12, 2023
Merged

feat: cosmos multisig #637

merged 181 commits into from
Oct 12, 2023

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Jul 3, 2023

From #384


Buglist 🐛 (some TODO) :

  • Looks like "Buy a TNS Account" button doesn't work on Second page after Multisig wallet creation.
    ==> FIXED
  • In "New Delegate Transaction" we should display Validators list in the input, to avoid to find Validators address manually.
    ==> FIXED
  • Plug the Network selector, to allow testnet or mainnet on the feature
    ==> FIXED
  • fix Broadcast status for transactions
    ==> FIXED
  • Allow to use TNS in the multisig creation instead of full adress (easy to add friends then)
    ==> FIXED
  • Once the multisig is created, it should be displayed on Top Right Drop Down menu when we click on Switch Account, and then should allow users to use all dApp features as a 'single wallet', creating tx proposals in Multisig interface.
    ==> We can select the multisig account, but have to plug miltisig on features
  • In "Transactions" screen, we should have displayed all tx, here we received 10 TORI (on mainnet) which are not displayed in this screen.
    ==> Need to fetch all transactions types, yes

quick TODO:

  • transaction form, missing labels
    ==> FIXED
  • "Transaction proposals" must become "Transactions" + add "Proposals" tab
    ==> FIXED
  • Prevent aproving transactions if the user is not in the multisig wallet (He musn't have access to the wallet)
    ==> FIXED
  • Enforce to add the multisig creator wallet adress by default at creation (but can be deleted)
    ==> FIXED

not so quick TODO:

  • Allow to give a name to each multisig wallet. Seems to be not possible to hang this is (Data in backend ? Local ? FaunaDB ?)
  • Plugs the behaviors when the user switches to a multisig wallet from TopMenu
  • Handle networks
    ==> FIXED

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit d124415
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/65280d17ad9ea20008a1168d
😎 Deploy Preview https://deploy-preview-637--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jul 3, 2023

Deploy Preview for testitori ready!

Name Link
🔨 Latest commit d124415
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/65280d173e6bbd0008494017
😎 Deploy Preview https://deploy-preview-637--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou changed the title Feat: Multisig Wallet feat: Multisig Wallet Jul 3, 2023
@WaDadidou WaDadidou force-pushed the feat/multisig-wallets branch 7 times, most recently from 88600e4 to 187ad77 Compare July 11, 2023 10:15
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
Signed-off-by: Norman Meier <[email protected]>
@n0izn0iz n0izn0iz changed the title feat: Multisig Wallet feat: cosmos multisig Oct 12, 2023
@n0izn0iz n0izn0iz marked this pull request as ready for review October 12, 2023 15:16
@n0izn0iz n0izn0iz merged commit e6c6a48 into main Oct 12, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants