Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sidebar minimized on load #635

Merged
merged 6 commits into from
Jul 12, 2023
Merged

fix: sidebar minimized on load #635

merged 6 commits into from
Jul 12, 2023

Conversation

omniwired
Copy link
Collaborator

No description provided.

@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 1e433f5
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/64ae5b7b2e2beb0008fd31da
😎 Deploy Preview https://deploy-preview-635--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Jun 30, 2023 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 1e433f5
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/64ae5b7bce2ded00076e3c71
😎 Deploy Preview https://deploy-preview-635--teritori-dapp.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@omniwired omniwired linked an issue Jun 30, 2023 that may be closed by this pull request
SIdebar minimized on load. State not kept (Open/close) on reload #633
Closed
@omniwired omniwired added the bug Something isn't working label Jun 30, 2023
@omniwired omniwired self-assigned this Jun 30, 2023
@omniwired omniwired force-pushed the issue/633/sidebar-minimized-on-load-state branch 2 times, most recently from 1f785e5 to dd2779e Compare June 30, 2023 01:41
@omniwired omniwired marked this pull request as ready for review June 30, 2023 01:43
WaDadidou
WaDadidou requested changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@WaDadidou WaDadidou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On mobile, we have to click twice on the sidebar button to open the sidebar, can you fix it ?

@omniwired omniwired requested a review from WaDadidou July 4, 2023 04:49
WaDadidou
WaDadidou previously approved these changes Jul 4, 2023
View reviewed changes
Copy link
Collaborator

@WaDadidou WaDadidou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@omniwired omniwired force-pushed the issue/633/sidebar-minimized-on-load-state branch from 3b2529c to 1e433f5 Compare July 12, 2023 07:51
n0izn0iz
n0izn0iz approved these changes Jul 12, 2023
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz merged commit bdd2e17 into main Jul 12, 2023
12 checks passed
@n0izn0iz n0izn0iz deleted the issue/633/sidebar-minimized-on-load-state branch July 12, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0izn0iz n0izn0iz n0izn0iz approved these changes

@WaDadidou WaDadidou WaDadidou left review comments

Assignees

@omniwired omniwired

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SIdebar minimized on load. State not kept (Open/close) on reload
3 participants
@omniwired @n0izn0iz @WaDadidou