feat: gno ghverify agent #1288
feat: gno ghverify agent #1288
Conversation
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
from
4db95bf
to
10a9bf1
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
2 times, most recently
from
051b7cf
to
207407a
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
2 times, most recently
from
0cbe6ef
to
e29c5e4
Compare
Villaquiranm
force-pushed
the
feat/gh_verify_agent
branch
from
e29c5e4
to
472bf06
Compare
|
maybe we should move that to a new repo? if we keep it here pls move it to |
gno_github_agent/.env
Outdated
| @@ -0,0 +1,5 @@ | |||
| GNO_MNEMONIC=source bonus chronic canvas draft south burst lottery vacant surface solve popular case indicate oppose farm nothing bullet exhibit title speed wink action roast | |||
There was a problem hiding this comment.
Is this normal that we keep this mnemonic here ?
There was a problem hiding this comment.
fixed on f4a2a1f
| err := client.db.Model(&db.Verification{}).Where("status = ?", string(db.VerificationStatusVerified)).Order("id desc").First(&verification).Error | ||
|
|
||
| if err != nil { | ||
| if errors.Is(err, gorm.ErrRecordNotFound) { |
There was a problem hiding this comment.
I dont see the purpose if this error checking :o both cases return the same value
There was a problem hiding this comment.
fixed on f4a2a1f
gno_github_agent/clientql/client.go
Outdated
| if attr.Key == "handle" { | ||
| handle = attr.Value | ||
| } | ||
| if attr.Key == "from" { |
There was a problem hiding this comment.
we should use else if to prevent one more unused comparison
There was a problem hiding this comment.
fixed on f4a2a1f
I think we should indeed move it to his own repository, I'll do as soon as this PR is approuved |
No description provided.