Fix #607, I hope: remove erroneous bits of text from version URL #608
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With @trishaoconnor, change the "makeTEIVersion" template in odds/teiodds.xsl so that a) it does not output the string "P5 Version
" as part of the version URL; and b) it outputs the version information on 1 line instead of two.
Get output to pass tests: * Update routine so that it deals with both “P5 Version …” and “Version …” * Update Makefile so that test35.rnc has these comments stripped out correctly * Update some expected results because of *slight* comment differences that should be ignored
jamescummings
approved these changes
Jun 10, 2023
martindholmes
approved these changes
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With @trishaoconnor, change the "makeTEIVersion" template in odds/teiodds.xsl so that
a) it does not output the string “P5 Version ” (or “Version ”) as part of the version URL; and
b) it outputs the version information on 1 line instead of two.
The good news is that I am quite confident that the new code works, in that it generates the expected output. The bad news is I have no idea if the expected output (since it is slightly different from the previous output) might break something that the build process did not test. (I have fixed the actual Test procedure, and Test2 passed without any problem.)
Warning to reviewers: I have also changed a whole bunch of whitespace, so be sure to ask GitHub to hide whitespace changes when you examine the changes. And I daresay the only file you really want to examine is teiodds.xsl. (All other changes are just fallout from changes to that file.)