Adding await to did export #1839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blackgirlbytes
requested review from
dayhaysoos,
angiejones,
EbonyLouis,
leordev and
acekyd
as code owners
✅ Deploy Preview for tbd-website-developer-new ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for tbd-website-developer ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
right now the docs are cloned in |
|
@angiejones thanks! Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
didDht.export returns a pending promise. We needed an await in front of it to handle the promise.
This pull request includes changes to the
site/testsuites/testsuite-javascript/__tests__/web5/build/decentralized-identifiers/how-to-create-did.test.jsfile to ensure asynchronous operations are handled correctly and to add additional assertions for better test coverage.Improvements to asynchronous handling and test coverage:
didDht.export()toawait didDht.export()to ensure the export operation completes before proceeding. (site/testsuites/testsuite-javascript/__tests__/web5/build/decentralized-identifiers/how-to-create-did.test.js)portableDid.urimatches thedidstring forDidDht. (site/testsuites/testsuite-javascript/__tests__/web5/build/decentralized-identifiers/how-to-create-did.test.js)didJwk.export()toawait didJwk.export()to ensure the export operation completes before proceeding. (site/testsuites/testsuite-javascript/__tests__/web5/build/decentralized-identifiers/how-to-create-did.test.js)portableDid.urimatches thedidstring forDidJwk. (site/testsuites/testsuite-javascript/__tests__/web5/build/decentralized-identifiers/how-to-create-did.test.js)