Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/improve walker init #80

Merged
merged 5 commits into from
Jul 20, 2023
Merged

Feature/improve walker init #80

merged 5 commits into from
Jul 20, 2023

Conversation

castellinilinguini
Copy link
Collaborator

@castellinilinguini castellinilinguini commented Jul 20, 2023

Description

Changes the generation of initial walker positions to a be responsive of the parameter limits.

Type of change

Please tick at least one of the options. Delete the other options.

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

How Has This Been Tested?

Please note/describe at least one tests that you ran to verify your changes.

  • Existing unit tests

Checklist For Contributor

  • My code follows the style guidelines of this project (I installed pre-commit)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I wrote my changes in the changelog in the [unreleased] section
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes

Checklist For Maintainers

  • Continuous Integration (CI) is successfully running
  • Do we want to release/tag a new version? [✔️ / ❌]
    • If yes, add a release to the changelog and set the new version in pyproject.toml. After the merge, tag the release!

@castellinilinguini castellinilinguini added the enhancement New feature or request label Jul 20, 2023
@castellinilinguini castellinilinguini self-assigned this Jul 20, 2023
Copy link
Collaborator

@kaiserls kaiserls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👍

@kaiserls kaiserls merged commit ec7c7a7 into main Jul 20, 2023
2 checks passed
@kaiserls kaiserls deleted the feature/improve_walker_init branch July 20, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants