Skip to content

Commit

Permalink
Adding Code Coverage (#21)
Browse files Browse the repository at this point in the history
  • Loading branch information
frets1700 authored Mar 26, 2024
1 parent 9072085 commit d3ed177
Show file tree
Hide file tree
Showing 3 changed files with 25 additions and 1 deletion.
1 change: 1 addition & 0 deletions .coveralls.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
service_name: symplicity-outlook
22 changes: 21 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,16 @@ on:
workflow_dispatch:

push:
branches:
- master
paths-ignore:
- '*.md'
- '.github/**'
- 'example/**'

pull_request:
branches:
- master
paths-ignore:
- '*.md'
- '.github/**'
Expand Down Expand Up @@ -49,5 +53,21 @@ jobs:
run: vendor/bin/phpstan

- name: Tests
run: vendor/bin/phpunit --coverage-clover clover.xml
run: |
mkdir -p ./build/logs
vendor/bin/phpunit --coverage-clover ./build/logs/clover.xml
- name: Verify coverage file is created
run: |
if [ ! -f ./build/logs/clover.xml ]; then
echo "clover.xml file was not created"
exit 1
fi
- name: Upload coverage
env:
COVERALLS_REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }}
run: |
composer global require php-coveralls/php-coveralls
php-coveralls --coverage_clover=./build/logs/clover.xml -v
3 changes: 3 additions & 0 deletions src/Notification/Subscription.php
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,9 @@ public function renew(string $subscriptionId, \DateTime $expiration, array $args
}
}

/**
* @param array<string, mixed> $args
*/
public function delete(string $subscriptionId, array $args = []): void
{
try {
Expand Down

0 comments on commit d3ed177

Please sign in to comment.