add support for phpunit 11

[wickedOne]

allow installation of phpunit 11
removed conflict section as well as it won't install phpunit <9.6 anyway?

requires SymfonyTest/SymfonyConfigTest#79 to be merged & tagged

[ju1ius]

Unfortunately, just tweaking the version constraints won't be enough to make it work, because PhpUnit 11 removes features that are currently used by this library (like the Constraint::exporter() method).

[ju1ius]

This will break when using the phpunit phar release, see #158.

[wickedOne]

yeah, i just noticed your merge request and was wondering whether it isn't a phar problem when a class is incorrectly vendored?

phpunit 11 does no longer include the exporter so not adding this dependency isn't really an option for this pr

[ju1ius]

phpunit 11 does no longer include the exporter

Nope, it's definitely there in the composer.json for v11, and also in the v11 phar release (still vendored as PHPUnit\SebastianBergmann\Exporter\Exporter).

was wondering whether it isn't a phar problem when a class is incorrectly vendored

I'm pretty sure that's the way it's supposed to be. The phpunit phar release basically vendors all it's dependencies under the PhpUnit root namespace.

[ju1ius]

not adding this dependency isn't really an option for this pr

You could add a compatibility factory, i.e. something like this:

use PhpUnit\SebastianBergmann\Exporter\Exporter as VendoredExporter;
use SebastianBergmann\Exporter\Exporter;

class PhpUnitCompatFactory {
  public static function exporter(): Exporter|VendoredExporter {
    return class_exists(VendoredExporter::class) ? new VendoredExporter() : new Exporter();
  }
}

[ju1ius]

Ah wait, I just noticed that you explicitely require sebastian/exporter in this PR, so this will probably work fine as long as the Exporter instances stay private.

[wickedOne]

yeah, i assume the phar vendors the exporter differently to prevent conflicts with a different version explicitly being installed in the repository so the actual fix is adding the sebastian/exporter to the composer requirements

[wickedOne]

piepline fails due to phpunit config.
should be an easy fix, but perhaps better to know upfront about the update stragety: will you release a new major for phpunt 11 or do you want phpunit 10 & 11 support in one release?

[Chris53897]

I guess it fix the lowest run, if you change it to ^10.5.11 || ^11.0

[dgriffiths-lanentech]

Do we have a rough idea of when this is going to be released? It’s preventing our application from being upgraded to PHPUnit 11.

[wickedOne]

Do we have a rough idea of when this is going to be released? It’s preventing our application from being upgraded to PHPUnit 11.

ping @matthiasnoback @Nyholm

[matthiasnoback]

@wickedOne Sorry, I'm not personally involved in these libraries anymore.

[simPod]

seems it's @stloyd now

[wickedOne]

@matthiasnoback sorry, i wasn't aware of that :|

[matthiasnoback]

@wickedOne No problem :)

[Nyholm]

Thank you for this PR.
And thank you for the reviews.

I think this looks correct. I'll merge this PR and hope that you will test it before we tag a new major version.

[wickedOne]

@Nyholm here's one of my repos running succesfully with phpunit 10.5.11 and phpunit 11.1.3 (both php 8.2 & 8.3) and the dev-master of this repo

be aware that SymfonyTest/SymfonyConfigTest#79 still needs to be merged & tagged and added to the composer.json of this repo

[alexander-schranz]

Is currently a released of this blocked by symfony/symfony#53812 ?

[Nyholm]

No, not what I know