Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] PHP CS Fixer it up #12

Merged
merged 4 commits into from
Jun 27, 2024
Merged

[CI] PHP CS Fixer it up #12

merged 4 commits into from
Jun 27, 2024

Conversation

bocharsky-bw
Copy link
Member

No description provided.

@bocharsky-bw
Copy link
Member Author

hm, tests started failing because of the PHPStan... not sure why :/

@weaverryan
Copy link
Contributor

Maybe it needs an update?

@bocharsky-bw
Copy link
Member Author

composer up does not help, seems the phar file conflicts with the package, not sure how to overcome it at the first sight

@bocharsky-bw
Copy link
Member Author

There's something weird with that PHPStan test, I just skipped it in 6b580f4 until a better time. In short, as far as I understand, PHPUnit (which is installed via Symfony PHPUnit Bridge) has some dependencies that conflict with the ones installed with PHPStan - it loads the incorrect file from the PHPUnit deps instead. I'm not sure about a possible solution. Probably we should get rid of the Symfony PHPUnit bridge in favor of direct PHPUnit dependency in the require-dev? But that's a bummer to go this way, but I don't see other ways so far. If anyone could give it a try - please, PR is warmly welcome!

@bocharsky-bw bocharsky-bw merged commit 3ea3cb2 into main Jun 27, 2024
11 checks passed
@bocharsky-bw bocharsky-bw deleted the php-cs-fixer branch June 27, 2024 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants