-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Increase purity of @generated
functions during tests with DispatchDoctor
#97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e745e3f.
MilesCranmer
changed the title
Prevent segfault from
Increase purity of Aug 1, 2024
@generated
@generated
functions during tests with DispatchDoctor
Benchmark Results
|
Hm, the |
Pull Request Test Coverage Report for Build 10206194772Details
💛 - Coveralls |
Yep, it's from no specialization. Fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some bugs in Julia itself related to
Core.Compiler.return_type
, especially the interaction with@generated
functions: JuliaLang/julia#55147 JuliaLang/julia#55332.While the changes in this PR do not get around the issue originally reported in that thread, they seem to be good ideas anyway, as they increase purity of the generated functions.
I also tried disabling the
@generated
functions and using JuliaLang/julia#55093 but sadly it hurts inference, the original@generated
functions are much better. In the future it seems like we should avoid@generated
functions whenever we can though. Only for things likeBase.Cartesian.@nif
here are they necessary.