Skip to content

Commit

Permalink
Merge pull request #94 from SymbolicML/faster-get-constants
Browse files Browse the repository at this point in the history
refactor: fix type instability within `get_constants`
  • Loading branch information
MilesCranmer authored Jul 4, 2024
2 parents 8fd110b + cdb63b0 commit cab1143
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/NodeUtils.jl
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,9 @@ given the output of this function.
Also return metadata that can will be used in the `set_constants!` function.
"""
function get_constants(tree::AbstractExpressionNode{T}) where {T}
refs = filter_map(is_node_constant, node -> Ref(node), tree, Ref{typeof(tree)})
refs = filter_map(
is_node_constant, node -> Ref(node), tree, Base.RefValue{typeof(tree)}
)
return map(ref -> ref[].val::T, refs), refs
# NOTE: Do not remove this `::T` as it is required for inference on empty collections
end
Expand Down

0 comments on commit cab1143

Please sign in to comment.